Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1358976

Re: [PATCH 1/2] usb: dwc3: core: Introduce dwc3_device_reinit()

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Roger Quadros <rogerq@ti.com> writes:
> [ text/plain ]
> We will need this function for a workaround.
> The function issues a softreset only to the device
> controller and performs minimal re-initialization
> so that the device controller can be usable.
>
> As some code is similar to dwc3_core_init() take out
> common code into dwc3_get_gctl_quirks().
>
> We add a new member (prtcap_mode) to struct dwc3 to
> keep track of the current mode in the PRTCAPDIR register.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>

I must say, I don't like this at all :-p There's ONE known silicon which
needs this because of a poor silicon integration which took an IP with a
known erratum where it can't be made to work on lower speeds and STILL
was integrated without a superspeed PHY.

There's a reason why I never tried to push this upstream myself ;-)

I'm really thinking we might be better off adding a quirk flag to skip
the metastability workaround and allow this ONE silicon to set the
controller to lower speed.

John, can you check with your colleagues if we would ever fall into
STAR#9000525659 if we set maximum speed to high speed during driver
probe and never touch it again ? I would assume we don't really fall
into the metastability workaround, right ? We're not doing any sort of
PM for dwc3...

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] usb: dwc3: gadget: Fix erratic interrupts and delayed enumeration Roger Quadros <rogerq@ti.com> - 2016-03-16 14:10 +0100
  Re: [PATCH 0/2] usb: dwc3: gadget: Fix erratic interrupts and delayed enumeration Felipe Balbi <balbi@kernel.org> - 2016-03-16 14:10 +0100
  [PATCH 2/2] usb: dwc3: gadget: usb: dwc3: run/stop metastability workaround Roger Quadros <rogerq@ti.com> - 2016-03-16 14:10 +0100
    Re: [PATCH 2/2] usb: dwc3: gadget: usb: dwc3: run/stop metastability workaround Felipe Balbi <balbi@kernel.org> - 2016-03-16 14:20 +0100
      Re: [PATCH 2/2] usb: dwc3: gadget: usb: dwc3: run/stop metastability  workaround Roger Quadros <rogerq@ti.com> - 2016-03-16 14:30 +0100
  [PATCH 1/2] usb: dwc3: core: Introduce dwc3_device_reinit() Roger Quadros <rogerq@ti.com> - 2016-03-16 14:10 +0100
    Re: [PATCH 1/2] usb: dwc3: core: Introduce dwc3_device_reinit() Felipe Balbi <balbi@kernel.org> - 2016-03-16 14:20 +0100
      Re: [PATCH 1/2] usb: dwc3: core: Introduce dwc3_device_reinit() Felipe Balbi <balbi@kernel.org> - 2016-03-16 15:00 +0100

csiph-web