Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1358844

spurious warning from of_i2c_register_device with fixed_regulator?

Show all headers | View raw

Hi!

We are getting this in the logs:

i2c i2c-0: of_i2c: invalid reg on /soc/i2c@ffc04000/vcc3p3-regulator

In the dts we have:

socfpga_cyclone5_sockit.dts:
        regulator_3_3v: vcc3p3-regulator {
	                compatible = "regulator-fixed";
		        regulator-name = "VCC3P3";
		        regulator-min-microvolt = <3300000>;
	                regulator-max-microvolt = <3300000>;
        };

Which seems to trigger

drivers/i2c/i2c-core.c:
      addr_be = of_get_property(node, "reg", &len);
                  if (!addr_be || (len < sizeof(*addr_be))) {
                       dev_err(&adap->dev, "of_i2c: invalid reg on %s\n",
...
		      
But we have fixed regulator there, it does not have "reg" property.

Git blame says: a430a3455f2c48995e06b359a82a1109a419e9ef. (And no, I
don't have exactly mainline kernel here, but it should be close enough.)

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

spurious warning from of_i2c_register_device with fixed_regulator? Pavel Machek <pavel@denx.de> - 2016-03-16 12:10 +0100
  Re: spurious warning from of_i2c_register_device with  fixed_regulator? Wolfram Sang <wsa@the-dreams.de> - 2016-03-16 12:30 +0100

csiph-web