Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1358900

Re: [PATCH] mmc: core: remove redundant memset of sdio_read_cccr

Show all headers | View raw

On 14 March 2016 at 05:41, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> When initializing sdio card, we get struct mmc_card
> from mmc_alloc_card which allocates it by kzalloc. So we
> don't need another memset while reading cccr.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

Thanks, applied for next!

Kind regards
Uffe


> ---
>
>  drivers/mmc/core/sdio.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
> index 467b3cf..bd44ba8 100644
> --- a/drivers/mmc/core/sdio.c
> +++ b/drivers/mmc/core/sdio.c
> @@ -106,8 +106,6 @@ static int sdio_read_cccr(struct mmc_card *card, u32 ocr)
>         unsigned char data;
>         unsigned char speed;
>
> -       memset(&card->cccr, 0, sizeof(struct sdio_cccr));
> -
>         ret = mmc_io_rw_direct(card, 0, 0, SDIO_CCCR_CCCR, 0, &data);
>         if (ret)
>                 goto out;
> --
> 2.3.7
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mmc: core: remove redundant memset of sdio_read_cccr Shawn Lin <shawn.lin@rock-chips.com> - 2016-03-14 05:50 +0100
  Re: [PATCH] mmc: core: remove redundant memset of sdio_read_cccr Ulf Hansson <ulf.hansson@linaro.org> - 2016-03-16 12:40 +0100

csiph-web