Re: [PATCH v4 1/3] mmc: sdhci: Set DMA mask when adding host

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Adrian Hunter <adrian.hunter@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/3] mmc: sdhci: Set DMA mask when adding host
Date	Wed, 16 Mar 2016 10:40:02 +0100
Message-ID	<rdg5Q-77V-9@gated-at.bofh.it> (permalink)
References	<r9SMq-4VR-11@gated-at.bofh.it> <r9SMr-4VR-23@gated-at.bofh.it> <rdfjs-6uw-13@gated-at.bofh.it> <rdfCO-6Vb-9@gated-at.bofh.it>
X-Original-To	Arnd Bergmann <arnd@arndb.de>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.24,344,1455004800"; d="scan'208";a="934972209"
Organization	Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	18
X-Original-Cc	Alexandre Courbot <acourbot@nvidia.com>, Ulf Hansson <ulf.hansson@linaro.org>, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, gnurou@gmail.com
X-Original-Date	Wed, 16 Mar 2016 11:26:48 +0200
X-Original-Message-ID	<56E926D8.7020908@intel.com>
X-Original-References	<1457316477-8153-1-git-send-email-acourbot@nvidia.com> <1457316477-8153-2-git-send-email-acourbot@nvidia.com> <56E91CB5.7030007@intel.com> <4404643.KcAFCUffYS@wuerfel>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1358769

Show key headers only | View raw

On 16/03/16 11:07, Arnd Bergmann wrote:
> On Wednesday 16 March 2016 10:43:33 Adrian Hunter wrote:
>>> +
>>> +     /* 32-bit mask as default & fallback */
>>> +     if (ret) {
>>> +             ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32));
>>
>> What happens if device enumeration (e.g. of_dma_configure) has already set a
>> more restrictive DMA mask?
>>
>>
> 
> In this case, dma_set_mask_and_coherent() is supposed to check the
> bus properties settings again and fail dma_set_mask_and_coherent().

So the logic this patch introduces will disable DMA in that case.  Would it
be better just to leave the DMA mask alone (as it does now for most sdhci
drivers) in the 32-bit case?

Thread

[PATCH v4 1/3] mmc: sdhci: Set DMA mask when adding host Alexandre Courbot <acourbot@nvidia.com> - 2016-03-07 03:10 +0100
  Re: [PATCH v4 1/3] mmc: sdhci: Set DMA mask when adding host Adrian Hunter <adrian.hunter@intel.com> - 2016-03-16 09:50 +0100
    Re: [PATCH v4 1/3] mmc: sdhci: Set DMA mask when adding host Arnd Bergmann <arnd@arndb.de> - 2016-03-16 10:10 +0100
      Re: [PATCH v4 1/3] mmc: sdhci: Set DMA mask when adding host Adrian Hunter <adrian.hunter@intel.com> - 2016-03-16 10:40 +0100
        Re: [PATCH v4 1/3] mmc: sdhci: Set DMA mask when adding host Arnd Bergmann <arnd@arndb.de> - 2016-03-16 11:10 +0100

csiph-web