Re: [GIT PULL] LED subsystem updates for 4.6

From	Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [GIT PULL] LED subsystem updates for 4.6
Date	2016-03-16 06:10 +0100
Message-ID	<rdbSx-4aJ-1@gated-at.bofh.it> (permalink)
References	<rcxV9-2t9-41@gated-at.bofh.it> <rcKfD-2br-3@gated-at.bofh.it> <rcS3w-7wi-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 15, 2016 at 12:51 AM, Jacek Anaszewski
<j.anaszewski@samsung.com> wrote:
>
> I just wanted to make sure that no unexpected problem has occurred
> after rebasing onto 4.5 release. Is it in some way more advantageous to
> base a pull request on rc7, than on a final release?

I'd rather see the pull request based on whatever it has been tested
on, and just keep it that way.

Any rebasing will inevitably mean that you are basically throwing all
previous testing out the window (or at least make it dubious).

Rebasing also makes it much harder to see the history (for example,
compare it against previous linux-next trees), so the rule really
should be that you should never rebase unless you have a major reason
to do so.

So for example, if you actually find a problem, and you notice that
that problem comes not from your own changes, but from the base you
picked - *then* you'd want to rebase to a more stable base. But a
rebase "just because" is not a good idea.

I'll pull it, since it looks fairly harmless, but basically please
don't do that again.

              Linus

Thread

[GIT PULL] LED subsystem updates for 4.6 Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-03-14 11:30 +0100
  Re: [GIT PULL] LED subsystem updates for 4.6 Stephen Rothwell <sfr@canb.auug.org.au> - 2016-03-15 00:40 +0100
    Re: [GIT PULL] LED subsystem updates for 4.6 Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-03-15 09:00 +0100
      Re: [GIT PULL] LED subsystem updates for 4.6 Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-16 06:10 +0100
        Re: [GIT PULL] LED subsystem updates for 4.6 Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-03-16 08:50 +0100
  Re: [GIT PULL] LED subsystem updates for 4.6 Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-16 06:20 +0100
    Re: [GIT PULL] LED subsystem updates for 4.6 Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-03-16 08:50 +0100

csiph-web