Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1360441
| From | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v8 08/10] tpm: Proxy driver for supporting multiple emulated TPMs |
| Date | 2016-03-18 10:00 +0100 |
| Message-ID | <rdYqe-3dS-3@gated-at.bofh.it> (permalink) |
| References | <rcn9o-3vt-3@gated-at.bofh.it> <rcn9o-3vt-9@gated-at.bofh.it> <rdqye-5Es-15@gated-at.bofh.it> <rdKdA-1Zz-9@gated-at.bofh.it> |
| Organization | Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo |
On Thu, Mar 17, 2016 at 01:45:20PM -0400, Stefan Berger wrote:
> On 03/16/2016 04:42 PM, Jarkko Sakkinen wrote:
> >On Sun, Mar 13, 2016 at 06:54:38PM -0400, Stefan Berger wrote:
> >>+
> >>+/* above flags */
> >>+#define VTPM_PROXY_FLAG_TPM2 1 /* emulator is TPM 2 */
> >>+
> >>+/* all supported flags */
> >>+#define VTPM_PROXY_FLAGS_ALL (VTPM_PROXY_FLAG_TPM2)
> >This can be moved inside the .c-file?
>
> I can move that.
>
> >
> >>+
> >>+#define VTPM_PROXY_MAGIC 0xa1
> >>+
> >>+#define VTPM_PROXY_IOC_NEW_DEV _IOW(VTPM_PROXY_MAGIC, 0x00, \
> >>+ struct vtpm_proxy_new_dev)
> >Could we simply replace these four lines with one line:
> >
> >#deifne VTPM_PROXY_IOC_NEW_DEV _IOW('t', 0x00, struct vtpm_proxy_new_dev);
>
> Does this make it better?
>
> >
> >I changed the magic but does it matter?
>
> I would keep the magic at '0xa1'. The documentation is written to '0xa1' now
> and seems to be good just as any other.
OK. Works for me. Keep the ioctl definition as it is.
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
I can move the constant. You don't have to send a new patch version
anymore. I start keeping this patch in my master but will not merge it
to next before 4.6-rc5 so at the moment it would be scheduled for 4.7.
Does this sound good for you?
Further improvemnts should be sent as separate fixup patches.
> Stefan
/Jarkko
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v8 00/10] Multi-instance vTPM proxy driver Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-03-14 00:00 +0100
[PATCH v8 05/10] tpm: Split out the devm stuff from tpmm_chip_alloc Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-03-14 00:00 +0100
[PATCH v8 03/10] tpm: Provide strong locking for device removal Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-03-14 00:00 +0100
[PATCH v8 09/10] tpm: Initialize TPM and get durations and timeouts Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-03-14 00:00 +0100
Re: [v8,09/10] tpm: Initialize TPM and get durations and timeouts Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-22 07:40 +0100
Re: [v8,09/10] tpm: Initialize TPM and get durations and timeouts Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-03-22 12:00 +0100
Re: [v8,09/10] tpm: Initialize TPM and get durations and timeoutsg Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-29 17:40 +0200
Re: [v8,09/10] tpm: Initialize TPM and get durations and timeoutsg Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-03-29 18:10 +0200
[PATCH v8 01/10] tpm: Get rid of chip->pdev Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-03-14 00:00 +0100
[PATCH v8 08/10] tpm: Proxy driver for supporting multiple emulated TPMs Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-03-14 00:00 +0100
Re: [PATCH v8 08/10] tpm: Proxy driver for supporting multiple emulated TPMs Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-14 17:30 +0100
Re: [PATCH v8 08/10] tpm: Proxy driver for supporting multiple emulated TPMs Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-16 13:20 +0100
Re: [PATCH v8 08/10] tpm: Proxy driver for supporting multiple emulated TPMs Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-03-16 15:00 +0100
Re: [PATCH v8 08/10] tpm: Proxy driver for supporting multiple emulated TPMs Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-03-16 18:50 +0100
Re: [PATCH v8 08/10] tpm: Proxy driver for supporting multiple emulated TPMs Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-16 21:40 +0100
Re: [PATCH v8 08/10] tpm: Proxy driver for supporting multiple emulated TPMs Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-16 21:50 +0100
Re: [PATCH v8 08/10] tpm: Proxy driver for supporting multiple emulated TPMs Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-03-17 18:50 +0100
Re: [PATCH v8 08/10] tpm: Proxy driver for supporting multiple emulated TPMs Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-18 10:00 +0100
Re: [PATCH v8 08/10] tpm: Proxy driver for supporting multiple emulated TPMs Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-18 14:10 +0100
Re: [PATCH v8 00/10] Multi-instance vTPM proxy driver Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-29 18:30 +0200
csiph-web