Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1360422

Re: [PATCH 1/2] x86/perf/intel/uncore: Make Intel uncore modular

From Peter Zijlstra <peterz@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] x86/perf/intel/uncore: Make Intel uncore modular
Date 2016-03-18 09:40 +0100
Message-ID <rdY6S-36M-15@gated-at.bofh.it> (permalink)
References <rdMfp-3co-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Mar 17, 2016 at 05:34:14AM -0700, kan.liang@intel.com wrote:
> +static void __exit intel_uncore_exit(void)
> +{
> +	cpu_notifier_register_done();

Did you even test this? That should be _begin();

> +	__unregister_cpu_notifier(&uncore_cpu_nb);
> +	uncore_types_exit(uncore_msr_uncores);
> +	uncore_pci_exit();
> +	cpu_notifier_register_done();
> +}
> +module_exit(intel_uncore_exit);
> -- 
> 2.5.0
> 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] x86/perf/intel/uncore: Make Intel uncore modular kan.liang@intel.com - 2016-03-17 21:00 +0100
  [PATCH 2/2] x86/perf/intel/uncore: Make Intel rapl modular kan.liang@intel.com - 2016-03-17 21:10 +0100
  Re: [PATCH 1/2] x86/perf/intel/uncore: Make Intel uncore modular Peter Zijlstra <peterz@infradead.org> - 2016-03-18 09:40 +0100
    Re: [PATCH 1/2] x86/perf/intel/uncore: Make Intel uncore modular Thomas Gleixner <tglx@linutronix.de> - 2016-03-18 10:00 +0100

csiph-web