Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1360396

Re: usb: gadget breakage on N900: bind UDC by name passed via usb_gadget_driver structure

From Ruslan Bilovol <ruslan.bilovol@gmail.com>
Newsgroups linux.kernel
Subject Re: usb: gadget breakage on N900: bind UDC by name passed via usb_gadget_driver structure
Date 2016-03-18 08:50 +0100
Message-ID <rdXku-2yP-9@gated-at.bofh.it> (permalink)
References <rdNEu-4pc-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Pavel

On Thu, Mar 17, 2016 at 11:26 PM, Pavel Machek <pavel@ucw.cz> wrote:
> Hi!
>
> USB gadget stops working for me on n900, if I merge

Could you please give us more details?
Which gadget driver do you use (g_nokia?)

>
> usb: gadget: bind UDC by name passed via usb_gadget_driver structure
>
> patch.
>
> commit 2284b29d3d9dd16490909962574d7f3fef83fd97
> Author: Ruslan Bilovol <ruslan.bilovol@gmail.com>
> Date:   Mon Nov 23 09:56:35 2015 +0100
>
>     usb: gadget: bind UDC by name passed via usb_gadget_driver
>     structure
>
>     Introduce new 'udc_name' member to usb_gadget_driver structure.
>         The 'udc_name' is a name of UDC that usb_gadget_driver should
>             be bound to. If udc_name is NULL, it will be bound to any
>                 available UDC.
>
>     Tested-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>         Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>
>             Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>                 Tested-by: Peter Chen <peter.chen@freescale.com>
>                     Signed-off-by: Felipe Balbi <balbi@ti.com>
>
>
> Patch is obvious enough... if there's someone who sets udc_name to
> NULL. Who is supposed to do that?

That is done automatically if you use libcomposite.
There is a static usb_gadget_driver composite_driver_template structure in
composite.c that is used in usb_composite_probe later (used by libcomposite
based gadgets). Since it's statically declared, 'udc_name' member is set
to NULL automatically.

Other gadgets (not based on libcomposite) use same approach with
statically declared usb_gadget_driver structure.

>
> (I have patch in my tree to make USB gadget work when it is not
> modular).

So this can be reproduced only on builtin gadget, right?

BTW, I have N900 and can try to play with it this weekend if you'll
give us more details.

Best regards,
Ruslan

>
> Best regards,
>                                                                         Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

usb: gadget breakage on N900: bind UDC by name passed via  usb_gadget_driver structure Pavel Machek <pavel@ucw.cz> - 2016-03-17 22:30 +0100
  Re: usb: gadget breakage on N900: bind UDC by name passed via  usb_gadget_driver structure Ruslan Bilovol <ruslan.bilovol@gmail.com> - 2016-03-18 08:50 +0100
    Re: usb: gadget breakage on N900: bind UDC by name passed via  usb_gadget_driver structure Pavel Machek <pavel@ucw.cz> - 2016-03-18 10:40 +0100
    Re: usb: gadget breakage on N900: bind UDC by name passed via  usb_gadget_driver structure Pavel Machek <pavel@ucw.cz> - 2016-03-18 21:30 +0100
      Re: usb: gadget breakage on N900: bind UDC by name passed via  usb_gadget_driver structure Marek Szyprowski <m.szyprowski@samsung.com> - 2016-03-21 13:00 +0100
        Re: usb: gadget breakage on N900: bind UDC by name passed via  usb_gadget_driver structure Pavel Machek <pavel@ucw.cz> - 2016-03-23 13:30 +0100
          Re: usb: gadget breakage on N900: bind UDC by name passed via  usb_gadget_driver structure Ruslan Bilovol <ruslan.bilovol@gmail.com> - 2016-03-24 01:50 +0100
            Re: usb: gadget breakage on N900: bind UDC by name passed via  usb_gadget_driver structure Ruslan Bilovol <ruslan.bilovol@gmail.com> - 2016-03-25 04:30 +0100
              Re: usb: gadget breakage on N900: bind UDC by name passed via  usb_gadget_driver structure Pavel Machek <pavel@ucw.cz> - 2016-03-25 22:20 +0100
                Re: usb: gadget breakage on N900: bind UDC by name passed via  usb_gadget_driver structure Ruslan Bilovol <ruslan.bilovol@gmail.com> - 2016-03-26 22:50 +0100
                Re: usb: gadget breakage on N900: bind UDC by name passed via  usb_gadget_driver structure Pavel Machek <pavel@ucw.cz> - 2016-03-27 22:30 +0200
                Re: usb: gadget breakage on N900: bind UDC by name passed via  usb_gadget_driver structure Ruslan Bilovol <ruslan.bilovol@gmail.com> - 2016-03-27 23:50 +0200
                Re: usb: gadget breakage on N900: bind UDC by name passed via  usb_gadget_driver structure Pavel Machek <pavel@ucw.cz> - 2016-03-28 23:40 +0200
                Re: usb: gadget breakage on N900: bind UDC by name passed via  usb_gadget_driver structure Pavel Machek <pavel@ucw.cz> - 2016-04-01 16:40 +0200
              Re: usb: gadget breakage on N900: bind UDC by name passed via  usb_gadget_driver structure Ruslan Bilovol <ruslan.bilovol@gmail.com> - 2016-03-26 22:40 +0100
                Re: usb: gadget breakage on N900: bind UDC by name passed via  usb_gadget_driver structure Ruslan Bilovol <ruslan.bilovol@gmail.com> - 2016-03-26 23:00 +0100

csiph-web