Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1360411

Re: [PATCH v5 6/6] mfd: intel_vuport: Add Intel virtual USB port MFD Driver

Show all headers | View raw

On Fri, 18 Mar 2016, Lu Baolu wrote:

> Some Intel platforms have an USB port mux controlled by GPIOs.
> There's a single ACPI platform device that provides both USB ID
> extcon device and a USB port mux device. This MFD driver will
> split the 2 devices for their respective drivers.
> 
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Suggested-by: David Cohen <david.a.cohen@linux.intel.com>

This should be at the top.

You couldn't have written the patch before it was suggested.

> Reviewed-by: Felipe Balbi <balbi@kernel.org>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

What is this sign-off meant to indicate?

> Reviewed-by: Lee Jones <lee.jones@linaro.org>

Why is this here?

a) I don't provide "Reviewed-by:" tags #alarmbells
b) I have never signed this patch off

> ---
>  MAINTAINERS                |  6 ++++

Seperate patch.

>  drivers/mfd/Kconfig        |  8 +++++
>  drivers/mfd/Makefile       |  1 +
>  drivers/mfd/intel-vuport.c | 74 ++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 89 insertions(+)
>  create mode 100644 drivers/mfd/intel-vuport.c

[...]

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/6] usb: add support for Intel dual role port mux Lu Baolu <baolu.lu@linux.intel.com> - 2016-03-18 07:40 +0100
  [PATCH v5 1/6] extcon: usb-gpio: add device binding for platform device Lu Baolu <baolu.lu@linux.intel.com> - 2016-03-18 07:40 +0100
  [PATCH v5 6/6] mfd: intel_vuport: Add Intel virtual USB port MFD Driver Lu Baolu <baolu.lu@linux.intel.com> - 2016-03-18 07:40 +0100
    Re: [PATCH v5 6/6] mfd: intel_vuport: Add Intel virtual USB port MFD  Driver Lee Jones <lee.jones@linaro.org> - 2016-03-18 09:10 +0100
      Re: [PATCH v5 6/6] mfd: intel_vuport: Add Intel virtual USB port MFD  Driver Lu Baolu <baolu.lu@linux.intel.com> - 2016-03-18 09:50 +0100
        Re: [PATCH v5 6/6] mfd: intel_vuport: Add Intel virtual USB port MFD  Driver Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-03-18 16:40 +0100
  [PATCH v5 3/6] usb: mux: add common code for Intel dual role port mux Lu Baolu <baolu.lu@linux.intel.com> - 2016-03-18 07:40 +0100
    Re: [PATCH v5 3/6] usb: mux: add common code for Intel dual role port  mux Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-18 09:00 +0100
      Re: [PATCH v5 3/6] usb: mux: add common code for Intel dual role port  mux Lu Baolu <baolu.lu@linux.intel.com> - 2016-03-18 09:30 +0100
  [PATCH v5 5/6] usb: mux: add driver for Intel drcfg controlled port mux Lu Baolu <baolu.lu@linux.intel.com> - 2016-03-18 07:40 +0100
  [PATCH v5 4/6] usb: mux: add driver for Intel gpio controlled port mux Lu Baolu <baolu.lu@linux.intel.com> - 2016-03-18 07:40 +0100
  [PATCH v5 2/6] extcon: usb-gpio: add support for ACPI gpio interface Lu Baolu <baolu.lu@linux.intel.com> - 2016-03-18 07:40 +0100

csiph-web