Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1360323

Re: [PATCH] nios2: Replace fdt_translate_address with of_flat_dt_translate_address

Show all headers | View raw

Hi Guenter,

On 03/17/2016 07:49 PM, Guenter Roeck wrote:
> nios2 builds fail with the following build error.
> 
> arch/nios2/kernel/prom.c: In function 'early_init_dt_scan_serial':
> arch/nios2/kernel/prom.c:100:2: error:
> 	implicit declaration of function 'fdt_translate_address'
> 
> Commit c90fe9c0394b ("of: earlycon: Move address translation to
> of_setup_earlycon()") replaced fdt_translate_address() with
> of_flat_dt_translate_address() but missed updating the nios2 code.

My bad.
The sad part is I even noted this other user of fdt_translate_address()
in a review of a different patch, and then overlooked it in my own patch. :/

Reviewed-by: Peter Hurley <peter@hurleysoftware.com>


> Fixes: c90fe9c0394b ("of: earlycon: Move address translation to of_setup_earlycon()")
> Cc: Peter Hurley <peter@hurleysoftware.com>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  arch/nios2/kernel/prom.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/nios2/kernel/prom.c b/arch/nios2/kernel/prom.c
> index 718dd197909f..367c5426157b 100644
> --- a/arch/nios2/kernel/prom.c
> +++ b/arch/nios2/kernel/prom.c
> @@ -97,8 +97,7 @@ static int __init early_init_dt_scan_serial(unsigned long node,
>  		return 0;
>  #endif
>  
> -	*addr64 = fdt_translate_address((const void *)initial_boot_params,
> -		node);
> +	*addr64 = of_flat_dt_translate_address(node);
>  
>  	return *addr64 == OF_BAD_ADDR ? 0 : 1;
>  }
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] nios2: Replace fdt_translate_address with of_flat_dt_translate_address Guenter Roeck <linux@roeck-us.net> - 2016-03-18 04:00 +0100
  Re: [PATCH] nios2: Replace fdt_translate_address with  of_flat_dt_translate_address Peter Hurley <peter@hurleysoftware.com> - 2016-03-18 04:30 +0100
    Re: [PATCH] nios2: Replace fdt_translate_address with  of_flat_dt_translate_address Peter Hurley <peter@hurleysoftware.com> - 2016-03-18 14:30 +0100

csiph-web