Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1360301

Re: [PATCH] x86/cpu: Do the feature test first in enable_sep_cpu()

Show all headers | View raw

On Wed, Mar 16, 2016 at 5:19 AM, Borislav Petkov <bp@alien8.de> wrote:
> From: Borislav Petkov <bp@suse.de>
>
> ... before assigning local vars. Kill out label too and simplify.
>
> No functionality change.

Acked-by: Andy Lutomirski <luto@kernel.org>

>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---
>  arch/x86/kernel/cpu/common.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index 249461f95851..63658d23d3dd 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -1030,12 +1030,12 @@ void enable_sep_cpu(void)
>         struct tss_struct *tss;
>         int cpu;
>
> +       if (!boot_cpu_has(X86_FEATURE_SEP))
> +               return;
> +
>         cpu = get_cpu();
>         tss = &per_cpu(cpu_tss, cpu);
>
> -       if (!boot_cpu_has(X86_FEATURE_SEP))
> -               goto out;
> -
>         /*
>          * We cache MSR_IA32_SYSENTER_CS's value in the TSS's ss1 field --
>          * see the big comment in struct x86_hw_tss's definition.
> @@ -1050,7 +1050,6 @@ void enable_sep_cpu(void)
>
>         wrmsr(MSR_IA32_SYSENTER_EIP, (unsigned long)entry_SYSENTER_32, 0);
>
> -out:
>         put_cpu();
>  }
>  #endif
> --
> 2.7.3
>



-- 
Andy Lutomirski
AMA Capital Management, LLC

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86/cpu: Do the feature test first in enable_sep_cpu() Borislav Petkov <bp@alien8.de> - 2016-03-16 13:30 +0100
  Re: [PATCH] x86/cpu: Do the feature test first in enable_sep_cpu() Andy Lutomirski <luto@amacapital.net> - 2016-03-18 02:50 +0100
  [tip:x86/asm] x86/cpu: Do the feature test first in  enable_sep_cpu() tip-bot for Borislav Petkov <tipbot@zytor.com> - 2016-03-29 14:30 +0200

csiph-web