Re: [PATCH] regulator: Rename files for Maxim PMIC drivers

From	Chanwoo Choi <cw00.choi@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] regulator: Rename files for Maxim PMIC drivers
Date	2016-03-18 01:40 +0100
Message-ID	<rdQCm-6sf-15@gated-at.bofh.it> (permalink)
References	<rdKng-22V-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Javier,

On 2016년 03월 18일 02:54, Javier Martinez Canillas wrote:
> Most Maxim PMIC regulator drivers are for sub-devices of Multi-Function
> Devices with drivers under drivers/mfd. But for many of these, the same
> object file name was used for both the MFD and the regulator drivers.
> 
> Having 2 different drivers with the same name causes a lot of confusion
> to Kbuild, specially if these are built as module since only one module
> will be installed and also exported symbols will be undefined due being
> overwritten by the other module during modpost.
> 
> For example, it fixes the following issue when both drivers are module:
> 
> $ make M=drivers/regulator/
>   ...
>   CC [M]  drivers/regulator//max14577.o
>   Building modules, stage 2.
>   MODPOST 1 modules
> WARNING: "maxim_charger_calc_reg_current" [drivers/regulator//max14577.ko] undefined!
> WARNING: "maxim_charger_currents" [drivers/regulator//max14577.ko] undefined!
> 
> Reported-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

Best Regards,
Chanwoo Choi

[snip]

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] regulator: Rename files for Maxim PMIC drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-17 19:00 +0100
  Re: [PATCH] regulator: Rename files for Maxim PMIC drivers Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-18 01:10 +0100
    Re: [PATCH] regulator: Rename files for Maxim PMIC drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-18 03:50 +0100
      Re: [PATCH] regulator: Rename files for Maxim PMIC drivers Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-18 04:40 +0100
  Re: [PATCH] regulator: Rename files for Maxim PMIC drivers Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-18 01:40 +0100

csiph-web