Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1360246

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

Show all headers | View raw

On Thu, Mar 17, 2016 at 08:36:00PM +0100, Peter Zijlstra wrote:
> On Wed, Mar 16, 2016 at 01:02:10PM -0400, Chris Metcalf wrote:
> > Currently you can only request a backtrace of either all cpus, or
> > all cpus but yourself.  It can also be helpful to request a remote
> > backtrace of a single cpu, and since we want that, the logical
> > extension is to support a cpumask as the underlying primitive.
> > 
> > This change modifies the existing lib/nmi_backtrace.c code to take
> > a cpumask as its basic primitive, and modifies the linux/nmi.h code
> > to use either the old "all/all_but_self" arch methods, or the new
> > "cpumask" method, depending on which is available.
> > 
> > The existing clients of nmi_backtrace (arm and x86) are converted
> > to using the new cpumask approach in this change.
> 
> So the past days I've been staring at RCU stall warns, and they can use
> a little of this. Their remote stack unwinds are less than useful.

The RCU stall-warn stack traces can be ugly, agreed.

That said, RCU used to use NMI-based stack traces, but switched to the
current scheme due to the NMIs having the unfortunate habit of locking
things up, which IIRC often meant no stack traces at all.  If I recall
correctly, one of the problems was self-deadlock in printk().

Have these problems been fixed?

							Thanx, Paul

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace()  methods Peter Zijlstra <peterz@infradead.org> - 2016-03-17 20:40 +0100
  Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace()  methods Chris Metcalf <cmetcalf@mellanox.com> - 2016-03-17 23:40 +0100
    Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace()  methods Peter Zijlstra <peterz@infradead.org> - 2016-03-17 23:40 +0100
      Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace()  methods Peter Zijlstra <peterz@infradead.org> - 2016-03-18 00:20 +0100
  Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace()  methods "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-03-18 00:00 +0100
    Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace()  methods Peter Zijlstra <peterz@infradead.org> - 2016-03-18 00:10 +0100
    Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace()  methods Peter Zijlstra <peterz@infradead.org> - 2016-03-18 00:20 +0100
      Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace()  methods "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-03-18 01:40 +0100
    Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace()  methods Chris Metcalf <cmetcalf@mellanox.com> - 2016-03-18 01:20 +0100
      Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace()  methods "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-03-18 01:50 +0100
        Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace()  methods Daniel Thompson <daniel.thompson@linaro.org> - 2016-03-18 10:50 +0100
          Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace()  methods "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-03-19 01:00 +0100

csiph-web