Re: [RFC v2 -next 1/2] virtio: Start feature MTU support

From	Stephen Hemminger <stephen@networkplumber.org>
Newsgroups	linux.kernel
Subject	Re: [RFC v2 -next 1/2] virtio: Start feature MTU support
Date	2016-03-17 23:10 +0100
Message-ID	<rdOhc-4TJ-7@gated-at.bofh.it> (permalink)
References	<rd4o2-7FE-11@gated-at.bofh.it> <rd4o2-7FE-9@gated-at.bofh.it> <rdomJ-4bz-1@gated-at.bofh.it> <rdNuN-4lS-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 17 Mar 2016 17:10:55 -0400
Aaron Conole <aconole@redhat.com> wrote:

> Stephen Hemminger <stephen@networkplumber.org> writes:
> 
> > On Tue, 15 Mar 2016 17:04:12 -0400
> > Aaron Conole <aconole@redhat.com> wrote:
> >
> >> --- a/include/uapi/linux/virtio_net.h
> >> +++ b/include/uapi/linux/virtio_net.h
> >> @@ -55,6 +55,7 @@
> >>  #define VIRTIO_NET_F_MQ	22	/* Device supports Receive Flow
> >>  					 * Steering */
> >>  #define VIRTIO_NET_F_CTRL_MAC_ADDR 23	/* Set MAC address */
> >> +#define VIRTIO_NET_F_MTU 25	/* Device supports Default MTU Negotiation */
> >>  
> >>  #ifndef VIRTIO_NET_NO_LEGACY
> >>  #define VIRTIO_NET_F_GSO	6	/* Host handles pkts w/ any GSO type */
> >> @@ -73,6 +74,8 @@ struct virtio_net_config {
> >>  	 * Legal values are between 1 and 0x8000
> >>  	 */
> >>  	__u16 max_virtqueue_pairs;
> >> +	/* Default maximum transmit unit advice */
> >> +	__u16 mtu;
> >>  } __attribute__((packed));
> >>  
> >>  /*
> >
> > You can't change user visible headers without breaking ABI.
> > This structure might be used by other user code. Also how can this
> > work if host is using old size of structure.
> 
> How else can this field be added and remain compliant with the spec? The
> spec requires that mtu be passed in the virtio_net_config field.
> 
> As for old sizeof, I think the absence of the VIRTIO_NET_F_MTU bit being
> asserted is confirmation that mtu is not valid (at least, it is implied
> in the spec).

Michael is right as long as the code checks for MTU flag before
referencing the mtu field, everything is fine.  Actually, the structure
is never used directly only by fetching fields with offsetof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC v2 -next 1/2] virtio: Start feature MTU support Aaron Conole <aconole@redhat.com> - 2016-03-15 22:10 +0100
  Re: [RFC v2 -next 1/2] virtio: Start feature MTU support Stephen Hemminger <stephen@networkplumber.org> - 2016-03-16 19:30 +0100
    Re: [RFC v2 -next 1/2] virtio: Start feature MTU support "Michael S. Tsirkin" <mst@redhat.com> - 2016-03-16 19:40 +0100
    Re: [RFC v2 -next 1/2] virtio: Start feature MTU support Aaron Conole <aconole@redhat.com> - 2016-03-17 22:20 +0100
      Re: [RFC v2 -next 1/2] virtio: Start feature MTU support Stephen Hemminger <stephen@networkplumber.org> - 2016-03-17 23:10 +0100

csiph-web