Re: arm: at91: do not disable/enable clocks in a row

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: arm: at91: do not disable/enable clocks in a row
Date	2016-03-17 19:10 +0100
Message-ID	<rdKwX-2ml-17@gated-at.bofh.it> (permalink)
References	(1 earlier) <qSm6g-3ZZ-47@gated-at.bofh.it> <r9iIW-5vt-5@gated-at.bofh.it> <ranGx-8tF-7@gated-at.bofh.it> <rauI2-4Kx-13@gated-at.bofh.it> <raJ4m-62X-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/03/2016 at 10:58:24 +0100, Sebastian Andrzej Siewior wrote :
> * Alexandre Belloni | 2016-03-08 19:39:10 [+0100]:
> 
> >Hi,
> Hi,
> 
> >Both are things to work on. In the mean time, I'm using the following
> >patch:
> >https://github.com/alexandrebelloni/linux/commit/3a2eae463fce18ae815b887a5c9ca1a657b180ac
> >
> >I understood from
> >http://lkml.iu.edu/hypermail/linux/kernel/1601.2/00941.html that this
> >was not your preferred course of action.
> 
> That was one thing.  What about this:
> 
> ---
> 
> Currently the driver will disable the clock and enable it one line later
> if it is switching from periodic mode into one shot.
> This can be avoided and causes a needless warning on -RT.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

I'm fine with that if you don't want to rely on the clock event state
machine.

Can you submit it to the mainline with:
Tested-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: Fix preempt-rt on AT91 Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-03-05 12:40 +0100
  Re: Fix preempt-rt on AT91 Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-03-08 12:10 +0100
    Re: Fix preempt-rt on AT91 Thomas Gleixner <tglx@linutronix.de> - 2016-03-08 12:30 +0100
    Re: Fix preempt-rt on AT91 Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-03-08 19:40 +0100
      arm: at91: do not disable/enable clocks in a row Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-03-09 11:00 +0100
        Re: arm: at91: do not disable/enable clocks in a row Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-03-17 19:10 +0100

csiph-web