Re: [PATCH] mmc: dw_mmc-rockchip: fix failing to mount partition with "discard"

Path	csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Shawn Lin <shawn.lin@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mmc: dw_mmc-rockchip: fix failing to mount partition with "discard"
Date	Thu, 17 Mar 2016 16:50:02 +0100
Message-ID	<rdIls-MU-19@gated-at.bofh.it> (permalink)
References	<r7MUO-60O-29@gated-at.bofh.it> <r83LZ-nH-31@gated-at.bofh.it>
X-263anti-Spam	KSV:0;
X-Mail-Gray	1
X-Abs-Checked	4
X-Rl-Sender	shawn.lin@rock-chips.com
X-Fst-To	linux-kernel@vger.kernel.org
X-Sender-IP	220.200.4.6
X-Login-Name	shawn.lin@rock-chips.com
X-Unique-Tag	<02a2bac6cc351b1074422392c59bc868>
X-Sender	lintao@rock-chips.com
User-Agent	Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	70
Organization	linux.* mail to news gateway
X-Original-Cc	Ulf Hansson <ulf.hansson@linaro.org>, linux-rockchip@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 17 Mar 2016 23:46:05 +0800
X-Original-Message-ID	<56EAD13D.8050400@rock-chips.com>
X-Original-References	<1456816373-32518-1-git-send-email-shawn.lin@rock-chips.com> <56D641FA.8010606@samsung.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1359969

Show key headers only | View raw

Hi jaehoon,

On 2016/3/2 9:29, Jaehoon Chung wrote:
> Hi Shawn.
>
> On 03/01/2016 04:12 PM, Shawn Lin wrote:
>> Without MMC_CAP_ERASE support, we fail to mount partition
>> with "discard" option since mmc_queue_setup_discard is limited
>> for checking mmc_can_erase. Without doing mmc_queue_setup_discard,
>> blk_queue_discard fails to test QUEUE_FLAG_DISCARD flag, so we get
>> the following log from f2fs(actually similar to other file system):
>>
>> mounting with "discard" option, but the device does not support discard
>
> We can enable MMC_CAP_ERASE by default, since other SoC also needs this capability.
> I had sent some patch for enabling by default, but at that time i didn't remember why not enabled by default.
> I will check that reason..and share the information.
>

Any good news? :)
Or let add it for dw_mmc by default?

> Best Regards,
> Jaehoon Chung
>
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>> ---
>>
>>   drivers/mmc/host/dw_mmc-rockchip.c | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
>> index 84e50f3..2eda118 100644
>> --- a/drivers/mmc/host/dw_mmc-rockchip.c
>> +++ b/drivers/mmc/host/dw_mmc-rockchip.c
>> @@ -234,11 +234,20 @@ static int dw_mci_rockchip_init(struct dw_mci *host)
>>   	return 0;
>>   }
>>
>> +/* Common capabilities of RK3288 SoC */
>> +static unsigned long dw_mci_rk3288_dwmmc_caps[4] = {
>> +	MMC_CAP_ERASE,
>> +	MMC_CAP_ERASE,
>> +	MMC_CAP_ERASE,
>> +	MMC_CAP_ERASE,
>> +};
>> +
>>   static const struct dw_mci_drv_data rk2928_drv_data = {
>>   	.init			= dw_mci_rockchip_init,
>>   };
>>
>>   static const struct dw_mci_drv_data rk3288_drv_data = {
>> +	.caps			= dw_mci_rk3288_dwmmc_caps,
>>   	.set_ios		= dw_mci_rk3288_set_ios,
>>   	.execute_tuning		= dw_mci_rk3288_execute_tuning,
>>   	.parse_dt		= dw_mci_rk3288_parse_dt,
>>
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>


-- 
Best Regards
Shawn Lin

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mmc: dw_mmc-rockchip: fix failing to mount partition with  "discard" Shawn Lin <shawn.lin@rock-chips.com> - 2016-03-17 16:50 +0100
  Re: [PATCH] mmc: dw_mmc-rockchip: fix failing to mount partition with  "discard" Jaehoon Chung <jh80.chung@samsung.com> - 2016-03-18 02:50 +0100
    Re: [PATCH] mmc: dw_mmc-rockchip: fix failing to mount partition with  "discard" Shawn Lin <shawn.lin@rock-chips.com> - 2016-03-18 05:50 +0100

csiph-web