Re: [PATCH v2 all 04/14] arc: use of_platform_default_populate() to populate default bus

From	Vineet Gupta <Vineet.Gupta1@synopsys.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 all 04/14] arc: use of_platform_default_populate() to populate default bus
Date	2016-03-17 12:30 +0100
Message-ID	<rdEhQ-6LW-17@gated-at.bofh.it> (permalink)
References	<rdedH-5Je-7@gated-at.bofh.it> <rdedI-5Je-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wednesday 16 March 2016 01:03 PM, Kefeng Wang wrote:
> Use helper of_platform_default_populate() in linux/of_platform
> when possible, instead of calling of_platform_populate() with
> the default match table.
>
> Acked-by: Vineet Gupta <vgupta@synopsys.com>
> Cc: Vineet Gupta <vgupta@synopsys.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>

Thx Kefeng. I've added this to ARC for-curr for 4.6

> ---
>  arch/arc/kernel/setup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c
> index cdc821d..401f51f 100644
> --- a/arch/arc/kernel/setup.c
> +++ b/arch/arc/kernel/setup.c
> @@ -464,7 +464,7 @@ static int __init customize_machine(void)
>  	 * Traverses flattened DeviceTree - registering platform devices
>  	 * (if any) complete with their resources
>  	 */
> -	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> +	of_platform_default_populate(NULL, NULL, NULL);

Perhaps too late - but can't of_platform_default_populate just be a static inline
calling of_platform_populate in the header rather than exporting yet another symbol !

-Vineet

>  
>  	if (machine_desc->init_machine)
>  		machine_desc->init_machine();

Thread

[PATCH v2 all 00/14] use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-03-16 08:40 +0100
  [PATCH v2 all 02/14] arm64: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-03-16 08:40 +0100
  [PATCH v2 all 04/14] arc: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-03-16 08:40 +0100
    Re: [PATCH v2 all 04/14] arc: use of_platform_default_populate() to  populate default bus Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-03-17 12:30 +0100
      Re: [PATCH v2 all 04/14] arc: use of_platform_default_populate() to  populate default bus Rob Herring <robh+dt@kernel.org> - 2016-03-17 14:30 +0100
        Re: [PATCH v2 all 04/14] arc: use of_platform_default_populate() to  populate default bus Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-03-17 15:20 +0100
          Re: [PATCH v2 all 04/14] arc: use of_platform_default_populate() to  populate default bus Rob Herring <robh+dt@kernel.org> - 2016-03-17 15:50 +0100
  [PATCH v2 all 08/14] nios2: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-03-16 08:40 +0100
  [PATCH v2 all 01/14] arm: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-03-16 08:40 +0100
    Re: [PATCH v2 all 01/14] arm: use of_platform_default_populate() to  populate default bus Viresh Kumar <viresh.kumar@linaro.org> - 2016-03-17 07:20 +0100
  [PATCH v2 all 14/14] Revert "of/platform: export of_default_bus_match_table" Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-03-16 08:40 +0100
  [PATCH v2 all 12/14] memory: omap-gpmc: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-03-16 08:50 +0100
    Re: [PATCH v2 all 12/14] memory: omap-gpmc: use  of_platform_default_populate() to populate default bus Roger Quadros <rogerq@ti.com> - 2016-03-16 11:40 +0100

csiph-web