Re: [PATCH 1/2] spi: sun4i: add DMA support

From	Michal Suchanek <hramrach@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] spi: sun4i: add DMA support
Date	2016-03-17 13:00 +0100
Message-ID	<rdEKS-6X2-11@gated-at.bofh.it> (permalink)
References	(4 earlier) <r9OIO-2d6-9@gated-at.bofh.it> <rb4Lv-4EC-3@gated-at.bofh.it> <rdAxz-4fU-1@gated-at.bofh.it> <rdDOO-6iN-3@gated-at.bofh.it> <rdEBc-6TE-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 17 March 2016 at 12:43, Mark Brown <broonie@kernel.org> wrote:
> On Thu, Mar 17, 2016 at 11:58:05AM +0100, Michal Suchanek wrote:
>> On 17 March 2016 at 08:27, Maxime Ripard
>
>> > You're mixing two things up: the fact that we can't do more than the
>> > FIFO length in PIO and that we're missing DMA support. We have patches
>> > to address both, and there's no depedency between the two.
>
>> The only thing is that although DMA is optional on pretty much any
>> system you will have DMA available unless you broke your config. You
>> really do want the DMA support when it is available. So there will be
>> nobody testing the non-DMA part and it will be prone to bitrot.
>
> Well, it might be worth doing PIO for very short transfers even if you
> have DMA - it's quite common for this to perform better.

That's what the driver does. The discussion revolves around the fact
that the driver does not attempt to work (even for very short
transfers) when the DMA channels are not configured and just bails
out. AFAICT the channels are always available when the system is
properly configured and the dmaengine driver loaded.

Very few device drivers would work with 63byte transfers only and the
code for manually driving the CS line in case the DMA engine fails to
configure will necessarily go untested most of the time since most
systems will have DMA configured properly.

Thanks

Michal

Thread

Re: [PATCH 1/2] spi: sun4i: add DMA support Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-03-06 22:50 +0100
  Re: [PATCH 1/2] spi: sun4i: add DMA support Michal Suchanek <hramrach@gmail.com> - 2016-03-10 10:10 +0100
    Re: [PATCH 1/2] spi: sun4i: add DMA support Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-03-17 08:30 +0100
      Re: [PATCH 1/2] spi: sun4i: add DMA support Michal Suchanek <hramrach@gmail.com> - 2016-03-17 12:00 +0100
        Re: [PATCH 1/2] spi: sun4i: add DMA support Mark Brown <broonie@kernel.org> - 2016-03-17 12:50 +0100
          Re: [PATCH 1/2] spi: sun4i: add DMA support Michal Suchanek <hramrach@gmail.com> - 2016-03-17 13:00 +0100
            Re: [PATCH 1/2] spi: sun4i: add DMA support Mark Brown <broonie@kernel.org> - 2016-03-17 13:00 +0100
            Re: [PATCH 1/2] spi: sun4i: add DMA support Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-03-18 21:30 +0100
              Re: [PATCH 1/2] spi: sun4i: add DMA support Mark Brown <broonie@kernel.org> - 2016-03-18 21:40 +0100

csiph-web