[patch] openvswitch: using a bit shift as a mask

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[patch] openvswitch: using a bit shift as a mask
Date	2016-03-17 11:50 +0100
Message-ID	<rdDF8-6fy-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The original condition is never true.  We want to test if BIT(0) is set
but the code is ANDing with zero.

Fixes: 05752523e565 ('openvswitch: Interface with NAT.')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c
index dc5eb29..29c82d6 100644
--- a/net/openvswitch/conntrack.c
+++ b/net/openvswitch/conntrack.c
@@ -668,7 +668,7 @@ static int ovs_ct_nat(struct net *net, struct sw_flow_key *key,
 	 */
 	if (info->nat & OVS_CT_NAT && ctinfo != IP_CT_NEW &&
 	    ct->status & IPS_NAT_MASK &&
-	    (!(ct->status & IPS_EXPECTED_BIT) || info->commit)) {
+	    (!(ct->status & IPS_EXPECTED) || info->commit)) {
 		/* NAT an established or related connection like before. */
 		if (CTINFO2DIR(ctinfo) == IP_CT_DIR_REPLY)
 			/* This is the REPLY direction for a connection

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[patch] openvswitch: using a bit shift as a mask Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-17 11:50 +0100
  Re: [patch] openvswitch: using a bit shift as a mask Jarno Rajahalme <jarno@ovn.org> - 2016-03-18 18:20 +0100

csiph-web