[RFT] iommu/amd: use subsys_initcall() on amdv2 iommu

From	"Luis R. Rodriguez" <mcgrof@kernel.org>
Newsgroups	linux.kernel
Subject	[RFT] iommu/amd: use subsys_initcall() on amdv2 iommu
Date	2016-03-15 23:20 +0100
Message-ID	<rd5tL-8lr-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

We need to ensure amd iommu v2 initializes before
driver uses such as drivers/gpu/drm/amd/amdkfd/kfd_module.c,
to do this make its init routine a subsys_initcall() which
ensures its load init is called first than modules when
built-in.

Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---

Can someone test if this patch enables both CONFIG_AMD_IOMMU_V2 and
CONFIG_HSA_AMD to be =y (built-in) without any conflicts ?

 drivers/iommu/amd_iommu_v2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/amd_iommu_v2.c b/drivers/iommu/amd_iommu_v2.c
index 56999d2fac07..60df645b9927 100644
--- a/drivers/iommu/amd_iommu_v2.c
+++ b/drivers/iommu/amd_iommu_v2.c
@@ -1004,5 +1004,5 @@ static void __exit amd_iommu_v2_exit(void)
 	destroy_workqueue(iommu_wq);
 }
 
-module_init(amd_iommu_v2_init);
+subsys_initcall(amd_iommu_v2_init);
 module_exit(amd_iommu_v2_exit);
-- 
2.7.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[RFT] iommu/amd: use subsys_initcall() on amdv2 iommu "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-03-15 23:20 +0100
  Re: [RFT] iommu/amd: use subsys_initcall() on amdv2 iommu Oded Gabbay <oded.gabbay@gmail.com> - 2016-03-16 08:10 +0100
    Re: [RFT] iommu/amd: use subsys_initcall() on amdv2 iommu Oded Gabbay <oded.gabbay@gmail.com> - 2016-03-16 11:20 +0100
      Re: [RFT] iommu/amd: use subsys_initcall() on amdv2 iommu "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-03-16 17:20 +0100
        Re: [RFT] iommu/amd: use subsys_initcall() on amdv2 iommu Joerg Roedel <joro@8bytes.org> - 2016-03-16 17:40 +0100
          Re: [RFT] iommu/amd: use subsys_initcall() on amdv2 iommu "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-03-16 18:00 +0100
            Re: [RFT] iommu/amd: use subsys_initcall() on amdv2 iommu Joerg Roedel <joro@8bytes.org> - 2016-03-16 18:20 +0100
    Re: [RFT] iommu/amd: use subsys_initcall() on amdv2 iommu Joerg Roedel <joro@8bytes.org> - 2016-03-16 11:20 +0100

csiph-web