Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1358230

[PATCH] regulator: Don't print error in devm_regulator_bulk_get() on -EPROBE_DEFER

From Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups linux.kernel
Subject [PATCH] regulator: Don't print error in devm_regulator_bulk_get() on -EPROBE_DEFER
Date 2016-03-15 21:40 +0100
Message-ID <rd3UZ-7gd-5@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


The regulators may not be available just because their driver's probe was
not executed and the regulators were not registered yet. So don't print an
error in this case to avoid polluting the kernel log and confuse the users.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 drivers/regulator/devres.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/devres.c b/drivers/regulator/devres.c
index 6ad8ab4c578d..3d023422e228 100644
--- a/drivers/regulator/devres.c
+++ b/drivers/regulator/devres.c
@@ -171,8 +171,9 @@ int devm_regulator_bulk_get(struct device *dev, int num_consumers,
 								NORMAL_GET);
 		if (IS_ERR(consumers[i].consumer)) {
 			ret = PTR_ERR(consumers[i].consumer);
-			dev_err(dev, "Failed to get supply '%s': %d\n",
-				consumers[i].supply, ret);
+			if (ret != -EPROBE_DEFER)
+				dev_err(dev, "Failed to get supply '%s': %d\n",
+					consumers[i].supply, ret);
 			consumers[i].consumer = NULL;
 			goto err;
 		}
-- 
2.5.0

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] regulator: Don't print error in devm_regulator_bulk_get() on -EPROBE_DEFER Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-15 21:40 +0100
  Re: [PATCH] regulator: Don't print error in  devm_regulator_bulk_get() on -EPROBE_DEFER Mark Brown <broonie@kernel.org> - 2016-03-16 11:10 +0100
    Re: [PATCH] regulator: Don't print error in devm_regulator_bulk_get()  on -EPROBE_DEFER Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-16 12:20 +0100
      Re: [PATCH] regulator: Don't print error in  devm_regulator_bulk_get() on -EPROBE_DEFER Mark Brown <broonie@kernel.org> - 2016-03-16 12:40 +0100
        Re: [PATCH] regulator: Don't print error in devm_regulator_bulk_get()  on -EPROBE_DEFER Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-16 12:50 +0100

csiph-web