Re: [PATCH 2/3] [media] am437x-vfpe: fix typo in vpfe_get_app_input_index

From	"Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] [media] am437x-vfpe: fix typo in vpfe_get_app_input_index
Date	2016-03-15 19:40 +0100
Message-ID	<rd22S-5TU-19@gated-at.bofh.it> (permalink)
References	<rcJtg-1DY-5@gated-at.bofh.it> <rcJtg-1DY-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Arnd,

Thanks for the patch.

On Mon, Mar 14, 2016 at 10:40 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> gcc-6 points out an obviously silly comparison in vpfe_get_app_input_index():
>
> drivers/media/platform/am437x/am437x-vpfe.c: In function 'vpfe_get_app_input_index':
> drivers/media/platform/am437x/am437x-vpfe.c:1709:27: warning: self-comparison always evaluats to true [-Wtautological-compare]
>        client->adapter->nr == client->adapter->nr) {
>                            ^~
>
> This was introduced in a slighly incorrect conversion, and it's
> clear that the comparison was meant to compare the iterator
> to the current subdev instead, as we do in the line above.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: d37232390fd4 ("[media] media: am437x-vpfe: match the OF node/i2c addr instead of name")
> ---

Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Cheers,
--Prabhakar Lad

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] [media] cobalt: add MTD dependency Arnd Bergmann <arnd@arndb.de> - 2016-03-14 23:50 +0100
  [PATCH 3/3] [media] v4l2-mc: remove unused dtv_demod variable Arnd Bergmann <arnd@arndb.de> - 2016-03-14 23:50 +0100
  [PATCH 2/3] [media] am437x-vfpe: fix typo in vpfe_get_app_input_index Arnd Bergmann <arnd@arndb.de> - 2016-03-14 23:50 +0100
    Re: [PATCH 2/3] [media] am437x-vfpe: fix typo in vpfe_get_app_input_index "Lad, Prabhakar" <prabhakar.csengg@gmail.com> - 2016-03-15 19:40 +0100

csiph-web