Re: Fix suspicious RCU usage in msr tracing.

From	Andi Kleen <ak@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: Fix suspicious RCU usage in msr tracing.
Date	2016-03-15 17:50 +0100
Message-ID	<rd0kp-4Bs-9@gated-at.bofh.it> (permalink)
References	<rcLY6-3nY-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> Back in January, Andi suggested swapping the order in which
> we ack the APIC irq, so it too is protected by rcu.
> There was no follow-up, and it seems to work for me.
> 
> Cc: Andi Kleen <ak@linux.intel.com>

Reviewed-by: Andi Kleen <ak@linux.intel.com>

-Andi

> Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
> 
> diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h
> index c80f6b6f3da2..e8c4fba52d3d 100644
> --- a/arch/x86/include/asm/apic.h
> +++ b/arch/x86/include/asm/apic.h
> @@ -644,8 +644,8 @@ static inline void entering_irq(void)
>  
>  static inline void entering_ack_irq(void)
>  {
> -	ack_APIC_irq();
>  	entering_irq();
> +	ack_APIC_irq();
>  }
>  
>  static inline void ipi_entering_ack_irq(void)

-- 
ak@linux.intel.com -- Speaking for myself only

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Fix suspicious RCU usage in msr tracing. Dave Jones <davej@codemonkey.org.uk> - 2016-03-15 02:30 +0100
  Re: Fix suspicious RCU usage in msr tracing. Andi Kleen <ak@linux.intel.com> - 2016-03-15 17:50 +0100

csiph-web