[PATCH] media: v4l2-compat-ioctl32: fix missing reserved field copy in put_v4l2_create32

From	Tiffany Lin <tiffany.lin@mediatek.com>
Newsgroups	linux.kernel
Subject	[PATCH] media: v4l2-compat-ioctl32: fix missing reserved field copy in put_v4l2_create32
Date	2016-03-14 11:50 +0100
Message-ID	<rcyet-2Bi-13@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Change-Id: Idac449fae5059a3ce255340e6da491f8bd83af7a
---
 drivers/media/v4l2-core/v4l2-compat-ioctl32.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/v4l2-core/v4l2-compat-ioctl32.c b/drivers/media/v4l2-core/v4l2-compat-ioctl32.c
index f38c076..109f687 100644
--- a/drivers/media/v4l2-core/v4l2-compat-ioctl32.c
+++ b/drivers/media/v4l2-core/v4l2-compat-ioctl32.c
@@ -280,7 +280,8 @@ static int put_v4l2_format32(struct v4l2_format *kp, struct v4l2_format32 __user
 static int put_v4l2_create32(struct v4l2_create_buffers *kp, struct v4l2_create_buffers32 __user *up)
 {
 	if (!access_ok(VERIFY_WRITE, up, sizeof(struct v4l2_create_buffers32)) ||
-	    copy_to_user(up, kp, offsetof(struct v4l2_create_buffers32, format)))
+	    copy_to_user(up, kp, offsetof(struct v4l2_create_buffers32, format)) ||
+	    copy_to_user(up->reserved, kp->reserved, sizeof(kp->reserved)))
 		return -EFAULT;
 	return __put_v4l2_format32(&kp->format, &up->format);
 }
-- 
1.7.9.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] media: v4l2-compat-ioctl32: fix missing reserved field copy in put_v4l2_create32 Tiffany Lin <tiffany.lin@mediatek.com> - 2016-03-14 11:50 +0100
  Re: [PATCH] media: v4l2-compat-ioctl32: fix missing reserved field  copy in put_v4l2_create32 Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2016-03-14 12:30 +0100
    Re: [PATCH] media: v4l2-compat-ioctl32: fix missing reserved field  copy in put_v4l2_create32 tiffany lin <tiffany.lin@mediatek.com> - 2016-03-14 13:30 +0100

csiph-web