Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1356940

Re: [PART1 RFC v2 06/10] svm: Add interrupt injection via AVIC

From Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
Newsgroups linux.kernel
Subject Re: [PART1 RFC v2 06/10] svm: Add interrupt injection via AVIC
Date 2016-03-14 06:30 +0100
Message-ID <rcteN-7Q2-7@gated-at.bofh.it> (permalink)
References <r94PD-3Vt-3@gated-at.bofh.it> <r94PE-3Vt-9@gated-at.bofh.it> <ra5qi-4EI-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 03/07/2016 10:36 PM, Paolo Bonzini wrote:
>
>
> On 04/03/2016 21:46, Suravee Suthikulpanit wrote:
>> +static void svm_deliver_avic_intr(struct kvm_vcpu *vcpu, int vec)
>> +{
>> +	struct vcpu_svm *svm = to_svm(vcpu);
>> +
>> +	kvm_lapic_set_vector(vec, avic_get_bk_page_entry(svm, APIC_IRR));
>> +
>> +	if (vcpu->mode == IN_GUEST_MODE) {
>> +		wrmsrl(SVM_AVIC_DOORBELL,
>> +		       __default_cpu_present_to_apicid(vcpu->cpu));
>> +	} else {
>> +		kvm_vcpu_kick(vcpu);
>> +	}
>
> You also need to add
>
> 	kvm_make_request(KVM_REQ_EVENT, vcpu);
>
> before the "if", similar to vmx_deliver_posted_interrupt.
>
> Paolo
>

Actually, I should only need that just before the kvm_cpu_kick(vcpu) 
isn't it. I don't think we need it in the case when sending doorbell.

Thanks,
Suravee

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PART1 RFC v2 06/10] svm: Add interrupt injection via AVIC Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> - 2016-03-04 21:50 +0100
  Re: [PART1 RFC v2 06/10] svm: Add interrupt injection via AVIC Paolo Bonzini <pbonzini@redhat.com> - 2016-03-07 16:40 +0100
    Re: [PART1 RFC v2 06/10] svm: Add interrupt injection via AVIC Radim Krčmář <rkrcmar@redhat.com> - 2016-03-08 23:00 +0100
      Re: [PART1 RFC v2 06/10] svm: Add interrupt injection via AVIC Paolo Bonzini <pbonzini@redhat.com> - 2016-03-09 12:20 +0100
        Re: [PART1 RFC v2 06/10] svm: Add interrupt injection via AVIC Radim Krčmář <rkrcmar@redhat.com> - 2016-03-09 17:10 +0100
          Re: [PART1 RFC v2 06/10] svm: Add interrupt injection via AVIC Paolo Bonzini <pbonzini@redhat.com> - 2016-03-14 13:30 +0100
    Re: [PART1 RFC v2 06/10] svm: Add interrupt injection via AVIC Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> - 2016-03-14 06:30 +0100
      Re: [PART1 RFC v2 06/10] svm: Add interrupt injection via AVIC Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> - 2016-03-14 10:00 +0100

csiph-web