Re: [RFC PATCH net-next 0/3] net: dsa: finer bridging control

From	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH net-next 0/3] net: dsa: finer bridging control
Date	2016-03-13 19:50 +0100
Message-ID	<rcjfr-140-1@gated-at.bofh.it> (permalink)
References	<rc80G-1Ob-3@gated-at.bofh.it> <rcijo-sc-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Andrew,

Andrew Lunn <andrew@lunn.ch> writes:

> On Sun, Mar 13, 2016 at 01:42:23AM -0500, Vivien Didelot wrote:
>> This patchset renames the bridging routines of the DSA layer, make the
>> unbridging routine return void, and rework the DSA netdev notifier handler,
>> similar to what the Mellanox Spectrum driver does.
>
> Tested-by: Andrew Lunn <andrew@lunn.ch>
>
> Do you think there could be some consolidation of code with Mellanox,
> and other switchdev devices? Moving it into the switchdev core?

We cannot move all this code to switchdev core, because switchdev is
stateless, so there is no place to register the netdevice notifier(s).

But it might be possible to provide a generic switchdev_netdevice_event
helper, using new switchdev operations to check a port device, and
add/del upper devices. I'll think about that.

Thanks!
Vivien

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH net-next 0/3] net: dsa: finer bridging control Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-03-13 07:50 +0100
  [RFC PATCH net-next 3/3] net: dsa: refine netdev event notifier Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-03-13 07:50 +0100
    Re: [RFC PATCH net-next 3/3] net: dsa: refine netdev event notifier Ido Schimmel <idosch@mellanox.com> - 2016-03-13 08:40 +0100
      Re: [RFC PATCH net-next 3/3] net: dsa: refine netdev event notifier Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-03-13 14:40 +0100
  [RFC PATCH net-next 2/3] net: dsa: make port_bridge_leave return void Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-03-13 07:50 +0100
  Re: [RFC PATCH net-next 0/3] net: dsa: finer bridging control Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-03-13 07:50 +0100
  [RFC PATCH net-next 1/3] net: dsa: rename port_*_bridge routines Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-03-13 07:50 +0100
  Re: [RFC PATCH net-next 0/3] net: dsa: finer bridging control Andrew Lunn <andrew@lunn.ch> - 2016-03-13 18:50 +0100
    Re: [RFC PATCH net-next 0/3] net: dsa: finer bridging control Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-03-13 19:50 +0100

csiph-web