Re: [PATCH v3 3/9] irqchip/gic-v2: Gather ACPI specific data in a single structure

From	Christoffer Dall <christoffer.dall@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 3/9] irqchip/gic-v2: Gather ACPI specific data in a single structure
Date	2016-03-13 19:20 +0100
Message-ID	<rciMp-RT-3@gated-at.bofh.it> (permalink)
References	<rao9z-e2-9@gated-at.bofh.it> <rao9B-e2-41@gated-at.bofh.it> <raFap-3s0-5@gated-at.bofh.it> <raFDr-3W3-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 09, 2016 at 01:18:14PM +0700, Julien Grall wrote:
> Hi Christoffer,
> 
> On 09/03/2016 12:47, Christoffer Dall wrote:
> >On Tue, Mar 08, 2016 at 11:29:27AM +0000, Julien Grall wrote:
> >>For now, there is only one member. More member will be added later.
> >
> >questionable commit message
> 
> What about:
> 
> "The ACPI code requires to use global variables in order to collect
> information from the tables.
> 
> For now only a single global variable is used, but more will be
> added in a subsequent patch. To make clear they are ACPI specific,
> gather all the information in a single structure."
> 

that's better.

> [...]
> 
> >>@@ -1316,7 +1319,7 @@ static int __init gic_v2_acpi_init(struct acpi_subtable_header *header,
> >>  		return -EINVAL;
> >>  	}
> >>
> >>-	cpu_base = ioremap(cpu_phy_base, ACPI_GIC_CPU_IF_MEM_SIZE);
> >>+	cpu_base = ioremap(acpi_data.cpu_phy_base, ACPI_GIC_CPU_IF_MEM_SIZE);
> >>  	if (!cpu_base) {
> >>  		pr_err("Unable to map GICC registers\n");
> >>  		return -ENOMEM;
> >>--
> >>1.9.1
> >>
> >super nit: I would use cpu_phys_base instead of cpu_phy_base, but I'll
> >leave it up to you.
> 
> I will update the commit message, so I will rename the variable too.
> 

Thanks,
-Christoffer

Thread

[PATCH v3 0/9] arm64: Add support of KVM with ACPI Julien Grall <julien.grall@arm.com> - 2016-03-08 12:40 +0100
  [PATCH v3 4/9] irqchip/gic-v2: Parse and export virtual GIC information Julien Grall <julien.grall@arm.com> - 2016-03-08 12:40 +0100
    Re: [PATCH v3 4/9] irqchip/gic-v2: Parse and export virtual GIC  information Christoffer Dall <christoffer.dall@linaro.org> - 2016-03-09 06:20 +0100
      Re: [PATCH v3 4/9] irqchip/gic-v2: Parse and export virtual GIC  information Julien Grall <julien.grall@arm.com> - 2016-03-14 13:20 +0100
  [PATCH v3 3/9] irqchip/gic-v2: Gather ACPI specific data in a single structure Julien Grall <julien.grall@arm.com> - 2016-03-08 12:40 +0100
    Re: [PATCH v3 3/9] irqchip/gic-v2: Gather ACPI specific data in a  single structure Christoffer Dall <christoffer.dall@linaro.org> - 2016-03-09 06:50 +0100
      Re: [PATCH v3 3/9] irqchip/gic-v2: Gather ACPI specific data in a  single structure Julien Grall <julien.grall@arm.com> - 2016-03-09 07:20 +0100
        Re: [PATCH v3 3/9] irqchip/gic-v2: Gather ACPI specific data in a  single structure Christoffer Dall <christoffer.dall@linaro.org> - 2016-03-13 19:20 +0100
  [PATCH v3 6/9] irqchip/gic-v3: Parse and export virtual GIC information Julien Grall <julien.grall@arm.com> - 2016-03-08 12:40 +0100
    Re: [PATCH v3 6/9] irqchip/gic-v3: Parse and export virtual GIC  information Christoffer Dall <christoffer.dall@linaro.org> - 2016-03-09 07:00 +0100
  [PATCH v3 7/9] KVM: arm/arm64: arch_timer: Rely on the arch timer to parse the firmware tables Julien Grall <julien.grall@arm.com> - 2016-03-08 12:40 +0100
    Re: [PATCH v3 7/9] KVM: arm/arm64: arch_timer: Rely on the arch  timer to parse the firmware tables Christoffer Dall <christoffer.dall@linaro.org> - 2016-03-09 07:00 +0100

csiph-web