Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1356686

Re: [PATCH v2 2/9] net: arc_emac: add phy reset is optional for device tree

Show all headers | View raw

Hello.

On 3/13/2016 12:07 PM, Caesar Wang wrote:

> This patch adds the following property for arc_emac.
>
> 1) reset-gpios:
> The phy reset-gpio is an optional property for arc emac device tree boot.
> Change the binding document to match the driver code.
>
> 2) phy-reset-duration:
> Different boards may require different phy reset duration. Add property
> phy-reset-duration for device tree probe, so that the boards that need
> a longer reset duration can specify it in their device tree.
>
> Anyway, we can add the above property for arc emac.
>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> ---
>
> Changes in v2: None

    Not true -- you renamed the reset prop.

>   Documentation/devicetree/bindings/net/arc_emac.txt | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/arc_emac.txt b/Documentation/devicetree/bindings/net/arc_emac.txt
> index a1d71eb..8e84b52 100644
> --- a/Documentation/devicetree/bindings/net/arc_emac.txt
> +++ b/Documentation/devicetree/bindings/net/arc_emac.txt
> @@ -7,6 +7,13 @@ Required properties:
>   - max-speed: see ethernet.txt file in the same directory.
>   - phy: see ethernet.txt file in the same directory.
>
> +Optional properties:
> +- reset-gpios : Should specify the gpio for phy reset

    Please leave the old name, "phy-reset-gpios" was surely better.

[...]

MBR, Sergei

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/9] arc_emac: fixes the emac issues and cleanup emac drivers Caesar Wang <wxt@rock-chips.com> - 2016-03-13 10:10 +0100
  [PATCH v2 1/9] net: arc_emac: make the rockchip emac document more compatible Caesar Wang <wxt@rock-chips.com> - 2016-03-13 10:10 +0100
  [PATCH v2 2/9] net: arc_emac: add phy reset is optional for device tree Caesar Wang <wxt@rock-chips.com> - 2016-03-13 10:10 +0100
    Re: [PATCH v2 2/9] net: arc_emac: add phy reset is optional for  device tree Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-13 15:40 +0100
  [PATCH v2 9/9] ARM: dts: rockchip: add support emac for RK3036 Caesar Wang <wxt@rock-chips.com> - 2016-03-13 10:10 +0100
  [PATCH v2 5/9] clk: rockchip: add node-id for rk3036 emac hclk Caesar Wang <wxt@rock-chips.com> - 2016-03-13 10:10 +0100
  [PATCH v2 7/9] clk: rockchip: add clock-id for rk3036 emac pll source clock Caesar Wang <wxt@rock-chips.com> - 2016-03-13 10:10 +0100
  [PATCH v2 6/9] clk: rockchip: associate the rk3036 HCLK_EMAC clock-id Caesar Wang <wxt@rock-chips.com> - 2016-03-13 10:10 +0100
    Re: [PATCH v2 6/9] clk: rockchip: associate the rk3036 HCLK_EMAC  clock-id Stephen Boyd <sboyd@codeaurora.org> - 2016-03-15 19:50 +0100
  [PATCH v2 8/9] clk: rockchip: associate SCLK_MAC_PLL and disable reparenting on rk3036 Caesar Wang <wxt@rock-chips.com> - 2016-03-13 10:20 +0100
    Re: [PATCH v2 8/9] clk: rockchip: associate SCLK_MAC_PLL and disable  reparenting on rk3036 Stephen Boyd <sboyd@codeaurora.org> - 2016-03-15 19:50 +0100
  [PATCH v2 3/9] net: arc_emac: support the phy reset for emac driver Caesar Wang <wxt@rock-chips.com> - 2016-03-13 10:20 +0100
  [PATCH v2 4/9] net: arc: trivial: cleanup the emac driver Caesar Wang <wxt@rock-chips.com> - 2016-03-13 10:20 +0100
  [PATCH v2.1 3/9] net: arc_emac: support the phy reset for emac driver Caesar Wang <wxt@rock-chips.com> - 2016-03-13 11:10 +0100
    Re: [PATCH v2.1 3/9] net: arc_emac: support the phy reset for emac  driver David Miller <davem@davemloft.net> - 2016-03-13 19:10 +0100
      Re: [PATCH v2.1 3/9] net: arc_emac: support the phy reset for emac  driver Caesar Wang <caesar.upstream@gmail.com> - 2016-03-14 01:30 +0100

csiph-web