Re: [PATCH v6 2/2] clk: qcom: Add support for RPM Clocks

From	Bjorn Andersson <bjorn.andersson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 2/2] clk: qcom: Add support for RPM Clocks
Date	2016-03-13 14:10 +0100
Message-ID	<rcdWp-6cV-3@gated-at.bofh.it> (permalink)
References	<qFX3A-479-11@gated-at.bofh.it> <qFX3A-479-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue 15 Dec 04:30 PST 2015, Georgi Djakov wrote:

[..]
> diff --git a/drivers/clk/qcom/clk-rpm.c b/drivers/clk/qcom/clk-rpm.c
[..]
> +
> +static struct clk_rpm *apq8064_clks[] = {
> +	[QCOM_RPM_PXO_CLK] = &apq8064_pxo,
> +	[QCOM_RPM_CXO_CLK] = &apq8064_cxo,
> +	[QCOM_RPM_APPS_FABRIC_CLK] = &apq8064_afab_clk,
> +	[QCOM_RPM_CFPB_CLK] = &apq8064_cfpb_clk,
> +	[QCOM_RPM_DAYTONA_FABRIC_CLK] = &apq8064_daytona_clk,
> +	[QCOM_RPM_EBI1_CLK] = &apq8064_ebi1_clk,
> +	[QCOM_RPM_MM_FABRIC_CLK] = &apq8064_mmfab_clk,
> +	[QCOM_RPM_MMFPB_CLK] = &apq8064_mmfpb_clk,
> +	[QCOM_RPM_SYS_FABRIC_CLK] = &apq8064_sfab_clk,
> +	[QCOM_RPM_SFPB_CLK] = &apq8064_sfpb_clk,
> +	[QCOM_RPM_QDSS_CLK] = &apq8064_qdss_clk,
> +};
> +

I do believe we did discuss this, but fwiw, do we really want the rpm
resource identifiers here? Rather than something clock specific
(from qcom,rpmcc.h)?

Regards,
Bjorn

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6 2/2] clk: qcom: Add support for RPM Clocks Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-03-13 14:10 +0100
  Re: [PATCH v6 2/2] clk: qcom: Add support for RPM Clocks Georgi Djakov <georgi.djakov@linaro.org> - 2016-03-15 18:20 +0100

csiph-web