Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1358023

Re: [PATCH v3 5/9] irqchip/gic-v3: Gather all ACPI specific data in a single structure

Show all headers | View raw

Hi Christoffer,

On 09/03/16 05:39, Christoffer Dall wrote:
> On Tue, Mar 08, 2016 at 11:29:29AM +0000, Julien Grall wrote:
>> Even though all the variables aren't marked with __initdata, they are
>> only used during initialization. So the structure is marked with
>> __initdata.
>
> Not sure I understand this commit message.
>
> As I see it, this commit includes two changes:
>
> 1. Mark the variables only used during init with __initdata
>
> 2. Move the variables into a structure
>
> If I get that right, can you argue for both changes?

What about:

"The ACPI code requires to use global variables in order to collect 
information from the tables.

To make clear those variables are ACPI specific, gather all of them in a 
single structure.

Furthermore, even if some of the variables are not marked with 
__initdata, they are all only used during the initialization. Therefore, 
the new variable, which hold the structure, can be marked __initdata."

Cheers,

-- 
Julien Grall

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 5/9] irqchip/gic-v3: Gather all ACPI specific data in a single structure Julien Grall <julien.grall@arm.com> - 2016-03-08 12:40 +0100
  Re: [PATCH v3 5/9] irqchip/gic-v3: Gather all ACPI specific data in  a single structure Christoffer Dall <christoffer.dall@linaro.org> - 2016-03-09 06:50 +0100
    Re: [PATCH v3 5/9] irqchip/gic-v3: Gather all ACPI specific data in a  single structure Julien Grall <julien.grall@arm.com> - 2016-03-15 13:40 +0100

csiph-web