Re: [PATCH] bus: mvebu-mbus: use %pad to print phys_addr_t

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] bus: mvebu-mbus: use %pad to print phys_addr_t
Date	2016-03-15 11:10 +0100
Message-ID	<rcU5l-Bl-9@gated-at.bofh.it> (permalink)
References	<rcU5k-Bl-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2016-03-15 at 11:03 +0100, Arnd Bergmann wrote:
> A recent change to the mbus driver added a warning printk that
> prints a phys_addr_t using the %x format string, which fails in
> case we build with 64-bit phys_addr_t:

Hey Arnd.

This is a bad patch subject, %pad is for a dma_addr_t.
The patch subject made me assume the patch was incorrect.

> > This uses the special %pa format string instead, so we always
> print the correct type.
[]
> -	pr_err("invalid dram address 0x%x\n", phyaddr);
> +	pr_err("invalid dram address %pa\n", &phyaddr);

The patch is good though.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] bus: mvebu-mbus: use %pad to print phys_addr_t Arnd Bergmann <arnd@arndb.de> - 2016-03-15 11:10 +0100
  Re: [PATCH] bus: mvebu-mbus: use %pad to print phys_addr_t Joe Perches <joe@perches.com> - 2016-03-15 11:10 +0100

csiph-web