Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1357856

Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size

From Christoph Hellwig <hch@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size
Date 2016-03-15 08:40 +0100
Message-ID <rcRKa-7pG-1@gated-at.bofh.it> (permalink)
References <r98Jz-6FF-3@gated-at.bofh.it> <r98JA-6FF-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Fri, Mar 04, 2016 at 04:56:10PM -0800, Darrick J. Wong wrote:
> Make sure that the offset and length arguments that we're using to
> construct WRITE SAME and DISCARD requests are actually aligned to the
> logical block size.  Failure to do this causes other errors in other
> parts of the block layer or the SCSI layer because disks don't support
> partial logical block writes.

Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/3] fallocate for block devices to provide zero-out "Darrick J. Wong" <darrick.wong@oracle.com> - 2016-03-05 02:00 +0100
  [PATCH 3/3] block: implement (some of) fallocate for block devices "Darrick J. Wong" <darrick.wong@oracle.com> - 2016-03-05 02:00 +0100
    Re: [PATCH 3/3] block: implement (some of) fallocate for block devices Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-05 04:10 +0100
      Re: [PATCH 3/3] block: implement (some of) fallocate for block  devices Christoph Hellwig <hch@infradead.org> - 2016-03-05 22:00 +0100
    Re: [PATCH 3/3] block: implement (some of) fallocate for block devices Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-05 04:20 +0100
      Re: [PATCH 3/3] block: implement (some of) fallocate for block  devices Christoph Hellwig <hch@infradead.org> - 2016-03-05 22:00 +0100
  [PATCH 1/3] block: invalidate the page cache when issuing  BLKZEROOUT. "Darrick J. Wong" <darrick.wong@oracle.com> - 2016-03-05 02:00 +0100
    Re: [PATCH 1/3] block: invalidate the page cache when issuing  BLKZEROOUT. Christoph Hellwig <hch@infradead.org> - 2016-03-15 08:40 +0100
  [PATCH 2/3] block: require write_same and discard requests align to  logical block size "Darrick J. Wong" <darrick.wong@oracle.com> - 2016-03-05 02:00 +0100
    Re: [PATCH 2/3] block: require write_same and discard requests align  to logical block size Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-05 04:10 +0100
    Re: [PATCH 2/3] block: require write_same and discard requests align  to logical block size Christoph Hellwig <hch@infradead.org> - 2016-03-15 08:40 +0100
  Re: [PATCH v6 0/3] fallocate for block devices to provide zero-out Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-05 04:20 +0100

csiph-web