Re: [PATCH v7] rtc: rewrite DS1302 using SPI

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7] rtc: rewrite DS1302 using SPI
Date	2016-03-15 01:20 +0100
Message-ID	<rcKSm-2ES-9@gated-at.bofh.it> (permalink)
References	<r4NNo-6Cu-9@gated-at.bofh.it> <r5iRe-45N-47@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

Thank you for your work!

On 23/02/2016 at 13:54:57 +0300, Sergei Ianovich wrote :
> -#ifdef CONFIG_SH_SECUREEDGE5410
> -#include <asm/rtc.h>
> -#include <mach/secureedge5410.h>
> -
> -#define	RTC_RESET	0x1000
> -#define	RTC_IODATA	0x0800
> -#define	RTC_SCLK	0x0400
> -
> -#define set_dp(x)	SECUREEDGE_WRITE_IOPORT(x, 0x1c00)
> -#define get_dp()	SECUREEDGE_READ_IOPORT()
> -#define ds1302_set_tx()
> -#define ds1302_set_rx()
> -

I would like to have a solution for secureedge5410 even if it is
untested. Else, we are breaking an existing platform without any
solution.

I've put the sh maintainers in copy, maybe they have an opinion. Else
I'll let your patch sit in linux-next for the next cycle.

I have further cleanups in that driver but they can probably be done
later.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v7] rtc: rewrite DS1302 using SPI Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-03-15 01:20 +0100

csiph-web