Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930

From	Nicolas Saenz Julienne <nicolassaenzj@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930
Date	2016-03-15 01:10 +0100
Message-ID	<rcKIG-2Bs-11@gated-at.bofh.it> (permalink)
References	<rc1sf-5p8-19@gated-at.bofh.it> <rc2oh-6ad-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Mar 12, 2016 at 04:27:29PM -0800, Greg KH wrote:
> On Sat, Mar 12, 2016 at 11:44:51PM +0000, Nicolas Saenz Julienne wrote:
> > Signed-off-by: Nicolas Saenz Julienne <nicolassaenzj@gmail.com>
> > ---
> >  drivers/usb/class/cdc-acm.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> > index fa4e239..9831607 100644
> > --- a/drivers/usb/class/cdc-acm.c
> > +++ b/drivers/usb/class/cdc-acm.c
> > @@ -1681,6 +1681,9 @@ static const struct usb_device_id acm_ids[] = {
> >  	{ USB_DEVICE(0x079b, 0x000f), /* BT On-Air USB MODEM */
> >  	.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> >  	},
> > +	{ USB_DEVICE(0x079b, 0x0088), /* SAGEM Monetel ELC930 */
> > +	.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> > +	},
>
> Why is this needed?  Does the descriptors not properly set the class
> device?
>
> thanks,
>
> greg k-h

Hi,
the device is missing all the ACM specific "extra" info on it's interface
descriptor. Which seems be triggering the "Zero length descriptor references"
error during the probe function. Adding the NO_UNION_NORMAL quirk seems to solve
the issue.
As for the class device, it seems to be ok, CDC (0x2).

	Nicolas

Thread

[PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930 Nicolas Saenz Julienne <nicolassaenzj@gmail.com> - 2016-03-13 00:50 +0100
  Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930 YU Bo <tsu.yubo@gmail.com> - 2016-03-13 01:20 +0100
  Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930 Greg KH <gregkh@linuxfoundation.org> - 2016-03-13 01:50 +0100
    Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930 Nicolas Saenz Julienne <nicolassaenzj@gmail.com> - 2016-03-15 01:10 +0100
      Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930 Oliver Neukum <oneukum@suse.com> - 2016-03-15 10:00 +0100

csiph-web