Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1357550
| From | Linus Torvalds <torvalds@linux-foundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 2/5] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops |
| Date | 2016-03-14 19:50 +0100 |
| Message-ID | <rcFJ0-7Cy-11@gated-at.bofh.it> (permalink) |
| References | (5 earlier) <rcEjT-6Ns-1@gated-at.bofh.it> <rcF6l-7mS-77@gated-at.bofh.it> <rcFfZ-7qA-57@gated-at.bofh.it> <rcFfZ-7qA-55@gated-at.bofh.it> <rcFpF-7uk-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Mar 14, 2016 at 11:24 AM, Andy Lutomirski <luto@amacapital.net> wrote:
>
> The code in my queue is, literally:
>
> bool ex_handler_rdmsr_unsafe(const struct exception_table_entry *fixup,
> struct pt_regs *regs, int trapnr)
> {
> WARN_ONCE(1, "unchecked MSR access error: RDMSR from 0x%x",
> (unsigned int)regs->cx);
>
> /* Pretend that the read succeeded and returned 0. */
> regs->ip = ex_fixup_addr(fixup);
> regs->ax = 0;
> regs->dx = 0;
> return true;
> }
> EXPORT_SYMBOL(ex_handler_rdmsr_unsafe);
I guess I can live with this, as long as we also extend the
early-fault handling to work with the special exception handlers.
And as long as people start understanding that killing the machine is
a bad bad bad thing. It's a debugging nightmare.
Linus
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 2/5] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops Andy Lutomirski <luto@kernel.org> - 2016-03-12 19:10 +0100
Re: [PATCH v4 2/5] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops Borislav Petkov <bp@alien8.de> - 2016-03-14 13:10 +0100
Re: [PATCH v4 2/5] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops Andy Lutomirski <luto@amacapital.net> - 2016-03-14 18:10 +0100
Re: [PATCH v4 2/5] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops Andy Lutomirski <luto@amacapital.net> - 2016-03-14 18:20 +0100
Re: [PATCH v4 2/5] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-14 19:10 +0100
Re: [PATCH v4 2/5] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-14 19:20 +0100
Re: [PATCH v4 2/5] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-14 19:20 +0100
Re: [PATCH v4 2/5] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops Andy Lutomirski <luto@amacapital.net> - 2016-03-14 19:30 +0100
Re: [PATCH v4 2/5] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops Andy Lutomirski <luto@amacapital.net> - 2016-03-14 19:50 +0100
Re: [PATCH v4 2/5] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops Ingo Molnar <mingo@kernel.org> - 2016-03-15 11:30 +0100
Re: [PATCH v4 2/5] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops Ingo Molnar <mingo@kernel.org> - 2016-03-15 11:30 +0100
Re: [PATCH v4 2/5] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-14 19:50 +0100
Re: [PATCH v4 2/5] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops Andy Lutomirski <luto@amacapital.net> - 2016-03-14 19:20 +0100
Re: [PATCH v4 2/5] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops Peter Zijlstra <peterz@infradead.org> - 2016-03-14 21:20 +0100
Re: [PATCH v4 2/5] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops Ingo Molnar <mingo@kernel.org> - 2016-03-15 11:30 +0100
csiph-web