Re: [PATCH 1/3] net: mediatek: use dma_addr_t correctly

From	John Crispin <blogic@openwrt.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] net: mediatek: use dma_addr_t correctly
Date	2016-03-14 19:10 +0100
Message-ID	<rcF6i-7mS-9@gated-at.bofh.it> (permalink)
References	<rcBm1-4LW-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 14/03/2016 15:07, Arnd Bergmann wrote:
> dma_alloc_coherent() expects a dma_addr_t pointer as its argument,
> not an 'unsigned int', and gcc correctly warns about broken
> code in the mtk_init_fq_dma function:
> 
> drivers/net/ethernet/mediatek/mtk_eth_soc.c: In function 'mtk_init_fq_dma':
> drivers/net/ethernet/mediatek/mtk_eth_soc.c:463:13: error: passing argument 3 of 'dma_alloc_coherent' from incompatible pointer type [-Werror=incompatible-pointer-types]
> 
> This changes the type of the local variable to dma_addr_t.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

thanks for the fixes



> ---
>  drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index ba3afa5d4640..3e42204adfe5 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -453,7 +453,7 @@ static inline void mtk_rx_get_desc(struct mtk_rx_dma *rxd,
>  /* the qdma core needs scratch memory to be setup */
>  static int mtk_init_fq_dma(struct mtk_eth *eth)
>  {
> -	unsigned int phy_ring_head, phy_ring_tail;
> +	dma_addr_t phy_ring_head, phy_ring_tail;
>  	int cnt = MTK_DMA_SIZE;
>  	dma_addr_t dma_addr;
>  	int i;
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] net: mediatek: use dma_addr_t correctly Arnd Bergmann <arnd@arndb.de> - 2016-03-14 15:10 +0100
  Re: [PATCH 1/3] net: mediatek: use dma_addr_t correctly David Miller <davem@davemloft.net> - 2016-03-14 18:10 +0100
  Re: [PATCH 1/3] net: mediatek: use dma_addr_t correctly John Crispin <blogic@openwrt.org> - 2016-03-14 19:10 +0100

csiph-web