Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1357326

Re: [PATCH v3] ASoC: cs35l32: avoid uninitialized variable access

Show all headers | View raw

On Mon, 14 Mar 2016, Arnd Bergmann wrote:

> gcc warns about the possibilty of accessing a property read from
> devicetree in cs35l32_i2c_probe() when it has not been initialized
> because CONFIG_OF is disabled:
> 
> sound/soc/codecs/cs35l32.c: In function 'cs35l32_i2c_probe':
> sound/soc/codecs/cs35l32.c:278:2: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 
> The code is actually correct because it checks the dev->of_node
> variable first and we know this is NULL here when CONFIG_OF
> is disabled, but Russell King noticed that it's broken when
> we probe the device using DT, and the properties are absent.
> 
> The code already has some checking for incorrect values, and
> I keep that checking unchanged here, but add an additional
> check for an error returned by the property accessor functions
> that now gets handled the same way as incorrect data in the
> properties.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v3: Restore a line that was accidentally removed, as pointed
>     out by Brian Austin.
> v2: fix bug in case of CONFIG_OF and missing properties
> v1: only address warning for the !CONFIG_OF case
> 
>  sound/soc/codecs/cs35l32.c | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
Acked-by: Brian Austin <brian.austin@cirrus.com>

Thanks

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v3] ASoC: cs35l32: avoid uninitialized variable access Brian Austin <brian.austin@cirrus.com> - 2016-03-14 16:00 +0100

csiph-web