Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1357300

Re: [PATCH] Firmware: broadcom sprom: clarifiy SSB dependency

Show all headers | View raw

On 14 March 2016 at 15:21, Arnd Bergmann <arnd@arndb.de> wrote:
> The broadcom firmware drvier calls into the ssb SPROM code if that
> is enabled, but it fails if the SSB code is in a loadable module
> because the bcm47xx firmware is always built-in:
>
> drivers/firmware/built-in.o: In function `bcm47xx_sprom_register_fallbacks':
> bcm47xx_sprom.c:(.text+0x11c4): undefined reference to `ssb_arch_register_fallback_sprom'
>
> This adds a Kconfig dependency to ensure that we cannot turn on the
> generic sprom support if the ssb sprom is in a module.

Can you attach your config that triggered this build error? I modified
condition to the:
#if IS_BUILTIN(CONFIG_SSB) && IS_ENABLED(CONFIG_SSB_SPROM)
which I believe should be enough.

I'm afraid your patch won't allow compiling SPROM driver with BCMA=y
and SSB as a module.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Firmware: broadcom sprom: clarifiy SSB dependency Arnd Bergmann <arnd@arndb.de> - 2016-03-14 15:30 +0100
  Re: [PATCH] Firmware: broadcom sprom: clarifiy SSB dependency Rafał Miłecki <zajec5@gmail.com> - 2016-03-14 15:40 +0100
    Re: [PATCH] Firmware: broadcom sprom: clarifiy SSB dependency Arnd Bergmann <arnd@arndb.de> - 2016-03-14 16:40 +0100
      Re: [PATCH] Firmware: broadcom sprom: clarifiy SSB dependency Rafał Miłecki <zajec5@gmail.com> - 2016-03-14 17:00 +0100

csiph-web