Re: [PATCH] i2c: i2c-core: do not use bus internal data

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] i2c: i2c-core: do not use bus internal data
Date	2016-03-14 15:30 +0100
Message-ID	<rcBFo-4SW-31@gated-at.bofh.it> (permalink)
References	<ra1PH-2jh-11@gated-at.bofh.it> <rcwPo-1Mw-5@gated-at.bofh.it> <rcwZ3-1Qb-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Mar 14, 2016 at 10:28:10AM +0100, Wolfram Sang wrote:
> 
> > This doesn't work. I see a number of these WARN_ON()s trigger and I
> > think the reason is that i2c_init() always fails now. The cause seems to
> > be that i2c_init() calls i2c_add_driver(&dummy_driver), which will now
> > always fail, because is_register is set to true *after* that call. There
> > is no way I see I2C working at all after this patch.
> 
> Same conclusion here. Too much trust applied to the original patch, mea
> culpa and sorry! Will send the fixup (tested!) in a minute.

Sorry for the mess. Fengguang Wu did send me a warning, but since I was
travelling i could not do much with it.
Sorry again.

regards
sudip

Thread

[PATCH] i2c: i2c-core: do not use bus internal data Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-03-07 12:50 +0100
  Re: [PATCH] i2c: i2c-core: do not use bus internal data Greg KH <gregkh@linuxfoundation.org> - 2016-03-07 18:00 +0100
    Re: [PATCH] i2c: i2c-core: do not use bus internal data Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-03-07 18:20 +0100
  Re: [PATCH] i2c: i2c-core: do not use bus internal data Wolfram Sang <wsa@the-dreams.de> - 2016-03-12 16:20 +0100
  Re: [PATCH] i2c: i2c-core: do not use bus internal data Thierry Reding <thierry.reding@gmail.com> - 2016-03-14 10:20 +0100
    Re: [PATCH] i2c: i2c-core: do not use bus internal data Wolfram Sang <wsa@the-dreams.de> - 2016-03-14 10:30 +0100
      Re: [PATCH] i2c: i2c-core: do not use bus internal data Thierry Reding <thierry.reding@gmail.com> - 2016-03-14 10:40 +0100
      Re: [PATCH] i2c: i2c-core: do not use bus internal data Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-03-14 15:30 +0100
    Re: [PATCH] i2c: i2c-core: do not use bus internal data Thierry Reding <thierry.reding@gmail.com> - 2016-03-14 10:30 +0100
      Re: [PATCH] i2c: i2c-core: do not use bus internal data Sudeep Holla <sudeep.holla@arm.com> - 2016-03-14 13:20 +0100

csiph-web