Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1357231
| Path | csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Peter Zijlstra <peterz@infradead.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/3] rtmutex: Add rt_mutex_init_waiter helper |
| Date | Mon, 14 Mar 2016 14:20:01 +0100 |
| Message-ID | <rcAzD-4e2-15@gated-at.bofh.it> (permalink) |
| References | <rauym-4FV-5@gated-at.bofh.it> <rauyn-4FV-25@gated-at.bofh.it> |
| X-Original-To | Davidlohr Bueso <dave@stgolabs.net> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.21 (2012-12-30) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 38 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | tglx@linutronix.de, mingo@kernel.org, bigeasy@linutronix.de, umgwanakikbuti@gmail.com, paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de> |
| X-Original-Date | Mon, 14 Mar 2016 14:16:21 +0100 |
| X-Original-Message-ID | <20160314131621.GX6356@twins.programming.kicks-ass.net> |
| X-Original-References | <1457461223-4301-1-git-send-email-dave@stgolabs.net> <1457461223-4301-3-git-send-email-dave@stgolabs.net> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1357231 |
Show key headers only | View raw
On Tue, Mar 08, 2016 at 10:20:22AM -0800, Davidlohr Bueso wrote:
> +++ b/kernel/futex.c
> @@ -2778,10 +2778,7 @@ static int futex_wait_requeue_pi(u32 __user *uaddr, unsigned int flags,
> * The waiter is allocated on our stack, manipulated by the requeue
> * code while we sleep on uaddr.
> */
> - debug_rt_mutex_init_waiter(&rt_waiter);
> - RB_CLEAR_NODE(&rt_waiter.pi_tree_entry);
> - RB_CLEAR_NODE(&rt_waiter.tree_entry);
> - rt_waiter.task = NULL;
> + rt_mutex_init_waiter(&rt_waiter);
>
> ret = get_futex_key(uaddr2, flags & FLAGS_SHARED, &key2, VERIFY_WRITE);
> if (unlikely(ret != 0))
> +static inline void
> +rt_mutex_init_waiter(struct rt_mutex_waiter *waiter)
> +{
> + debug_rt_mutex_init_waiter(waiter);
> +
> + RB_CLEAR_NODE(&waiter->pi_tree_entry);
> + RB_CLEAR_NODE(&waiter->tree_entry);
> + waiter->task = NULL;
> +}
Just thinking, would not something like:
#define DEFINE_RT_WAITER(name) \
struct rt_mutex_waiter name = { \
.tree_entry = __INIT_RB_NODE(name.tree_entry), \
.pi_tree_entry = __INIT_RB_NODE(name.pi_tree_entry), \
__INIT_RT_WAITER_DEBUG(name) \
}
Be nicer? That way we're sure the whole structure is initialized.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 2/3] rtmutex: Add rt_mutex_init_waiter helper Davidlohr Bueso <dave@stgolabs.net> - 2016-03-08 19:30 +0100 Re: [PATCH 2/3] rtmutex: Add rt_mutex_init_waiter helper Peter Zijlstra <peterz@infradead.org> - 2016-03-14 14:20 +0100
csiph-web