Re: [PATCH] block: don't optimize for non-cloned bio in bio_get_last_bvec()

From	Jens Axboe <axboe@kernel.dk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] block: don't optimize for non-cloned bio in bio_get_last_bvec()
Date	2016-03-13 05:30 +0100
Message-ID	<rc5Pb-h2-1@gated-at.bofh.it> (permalink)
References	<rbTbj-7BO-11@gated-at.bofh.it> <rc5ma-8fn-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03/12/2016 08:58 PM, Jens Axboe wrote:
> On 03/12/2016 07:56 AM, Ming Lei wrote:
>> For !BIO_CLONED bio, we can use .bi_vcnt safely, but it
>> doesn't mean we can just simply return .bi_io_vec[.bi_vcnt - 1]
>> because the start postion may have been moved in the middle of
>> the bvec, such as splitting in the middle of bvec.
>
> Added and tested.

And Ming, let's not get a repeat of this situation. For critical fixes, 
it has to be spot on for post -rc1, especially for code that is 
notoriously difficult to get right. Fixes are obviously fine, but it has 
to be just enough to fix the regression, no more. This has been too lax, 
I expect this to improve.

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] block: don't optimize for non-cloned bio in bio_get_last_bvec() Ming Lei <ming.lei@canonical.com> - 2016-03-12 16:00 +0100
  Re: [PATCH] block: don't optimize for non-cloned bio in  bio_get_last_bvec() Jens Axboe <axboe@kernel.dk> - 2016-03-13 05:00 +0100
    Re: [PATCH] block: don't optimize for non-cloned bio in  bio_get_last_bvec() Jens Axboe <axboe@kernel.dk> - 2016-03-13 05:30 +0100

csiph-web