[PATCH 1/1] mfd: core: fix ACPI child matching by _HID/_CID

From	Irina Tirdea <irina.tirdea@intel.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/1] mfd: core: fix ACPI child matching by _HID/_CID
Date	2016-03-13 02:10 +0100
Message-ID	<rc2HF-6xE-13@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

If MDF child devices have separate ACPI nodes identified
by _HID/_CID, they will not be assigned the intended
ACPI companion.

acpi_match_device_ids will return 0 if a the child device
matches the _HID/_CID, so this patch changes the matching
condition to check for 0 on success.

Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
---
 drivers/mfd/mfd-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index 88bd1b1..409da01 100644
--- a/drivers/mfd/mfd-core.c
+++ b/drivers/mfd/mfd-core.c
@@ -107,7 +107,7 @@ static void mfd_acpi_add_device(const struct mfd_cell *cell,
 
 			strlcpy(ids[0].id, match->pnpid, sizeof(ids[0].id));
 			list_for_each_entry(child, &parent->children, node) {
-				if (acpi_match_device_ids(child, ids)) {
+				if (!acpi_match_device_ids(child, ids)) {
 					adev = child;
 					break;
 				}
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] mfd: core: fix ACPI child matching by _HID/_CID Irina Tirdea <irina.tirdea@intel.com> - 2016-03-13 02:10 +0100
  Re: [PATCH 1/1] mfd: core: fix ACPI child matching by _HID/_CID Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-03-14 16:10 +0100

csiph-web