Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev
Date	2016-03-11 18:20 +0100
Message-ID	<rbyTg-161-21@gated-at.bofh.it> (permalink)
References	(3 earlier) <r3ASf-CA-23@gated-at.bofh.it> <r3QtY-3Bd-15@gated-at.bofh.it> <r3Scp-4Z3-3@gated-at.bofh.it> <r8hcf-1c4-37@gated-at.bofh.it> <r8xAm-4OI-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

Sorry about the delay.

On Thu, Mar 03, 2016 at 10:12:01AM +0100, Jiri Slaby wrote:
> On 03/02/2016, 04:45 PM, Tejun Heo wrote:
> > On Fri, Feb 19, 2016 at 01:10:00PM +0100, Jiri Slaby wrote:
> >>> 1. didn't help, the problem persists. So I haven't applied the patch from 2.
> >>
> >> FWIW I dumped more info about the wq:
> >> wq->name='hci0' pwq=ffff8800390d7600 wq->dfl_pwq=ffff8800390d5200
> >> pwq->refcnt=2 pwq->nr_active=0 delayed_works: <nothing>
> > 
> > Can you please print out the same info for all pwq's during shutdown?
> > It looks like we're leaking pwq refcnt but I can't spot a place where
> > that could happen on an empty pwq.
> 
> I have not done that yet, but today, I see:
> destroy_workqueue: name='req_hci0' pwq=ffff88002f590300
> wq->dfl_pwq=ffff88002f591e00 pwq->refcnt=2 pwq->nr_active=0 delayed_works:
>    pwq 12: cpus=0-1 node=0 flags=0x4 nice=-20 active=0/1
>      in-flight: 18568:wq_barrier_func

So, this means that there's flush_work() racing against workqueue
destruction, which can't be safe. :(

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: net/bluetooth: workqueue destruction WARNING in  hci_unregister_dev Tejun Heo <tj@kernel.org> - 2016-03-11 18:20 +0100
  Re: net/bluetooth: workqueue destruction WARNING in  hci_unregister_dev Jiri Slaby <jslaby@suse.cz> - 2016-03-17 13:10 +0100

csiph-web