Re: [PATCH 0/3] OOM detection rework v4

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/3] OOM detection rework v4
Date	2016-03-11 16:30 +0100
Message-ID	<rbxaO-88q-5@gated-at.bofh.it> (permalink)
References	<qG2wi-7PJ-13@gated-at.bofh.it> <rbsNQ-4Mh-15@gated-at.bofh.it> <rbuZk-6Kj-17@gated-at.bofh.it> <rbvsm-6X3-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri 11-03-16 22:32:02, Tetsuo Handa wrote:
> Michal Hocko wrote:
> > On Fri 11-03-16 19:45:29, Tetsuo Handa wrote:
> > > (Posting as a reply to this thread.)
> > 
> > I really do not see how this is related to this thread.
> 
> All allocating tasks are looping at
> 
>                         /*
>                          * If we didn't make any progress and have a lot of
>                          * dirty + writeback pages then we should wait for
>                          * an IO to complete to slow down the reclaim and
>                          * prevent from pre mature OOM
>                          */
>                         if (!did_some_progress && 2*(writeback + dirty) > reclaimable) {
>                                 congestion_wait(BLK_RW_ASYNC, HZ/10);
>                                 return true;
>                         }
> 
> in should_reclaim_retry().
> 
> should_reclaim_retry() was added by OOM detection rework, wan't it?

What happens without this patch applied. In other words, it all smells
like the IO got stuck somewhere and the direct reclaim cannot perform it
so we have to wait for the flushers to make a progress for us. Are those
stuck? Is the IO making any progress at all or it is just too slow and
it would finish actually.  Wouldn't we just wait somewhere else in the
direct reclaim path instead.

-- 
Michal Hocko
SUSE Labs

Thread

Re: [PATCH 0/3] OOM detection rework v4 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-03-11 11:50 +0100
  Re: [PATCH 0/3] OOM detection rework v4 Michal Hocko <mhocko@kernel.org> - 2016-03-11 14:10 +0100
    Re: [PATCH 0/3] OOM detection rework v4 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-03-11 14:40 +0100
      Re: [PATCH 0/3] OOM detection rework v4 Michal Hocko <mhocko@kernel.org> - 2016-03-11 16:30 +0100
        Re: [PATCH 0/3] OOM detection rework v4 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-03-11 17:50 +0100
          Re: [PATCH 0/3] OOM detection rework v4 Michal Hocko <mhocko@kernel.org> - 2016-03-11 18:10 +0100
            Re: [PATCH 0/3] OOM detection rework v4 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-03-11 18:30 +0100
              Re: [PATCH 0/3] OOM detection rework v4 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-03-12 05:10 +0100
                Re: [PATCH 0/3] OOM detection rework v4 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-03-13 15:50 +0100

csiph-web