Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1356027

Re: [PATCH] x86: Enable full randomization on i386 and X86_32.

Show all headers | View raw

On Fri, Mar 11, 2016 at 12:53 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Kees Cook <keescook@chromium.org> wrote:
>
>> On Thu, Mar 10, 2016 at 12:53 PM, Arjan van de Ven
>> <arjan@linux.intel.com> wrote:
>> >> Arjan, or other folks, can you remember why x86_32 disabled mmap
>> >> randomization here? There doesn't seem to be a good reason for it that
>> >> I see.
>> >
>> >
>> > for unlimited stack it got really messy with threaded apps.
>>
>> Seems like it'd only cause problems for really really giant processes?
>> (I think it's telling that the other 32-bit archs don't disable ASLR
>> in this case...)
>
> IIRC there was some sort of specific breakage with unlimited stack apps - I don't
> remember the exact details.
>
>> > anyway, I don't mind seeing if this will indeed work, with time running out
>> > where 32 bit is going extinct... in a few years we just won't have enough
>> > testing on this kind of change anymore.
>>
>> Sounds good. Ingo, can you pull this in and we can try it for -next?
>
> Ok, we can certainly try. If there's breakage with old distros then we might need
> to put this behind a legacy Kconfig switch.

Okay, sounds good. Thanks!

-Kees

-- 
Kees Cook
Chrome OS & Brillo Security

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86: Enable full randomization on i386 and X86_32. Hector Marco-Gisbert <hecmargi@upv.es> - 2016-03-10 21:10 +0100
  Re: [PATCH] x86: Enable full randomization on i386 and X86_32. Kees Cook <keescook@chromium.org> - 2016-03-10 21:30 +0100
    Re: [PATCH] x86: Enable full randomization on i386 and X86_32. Arjan van de Ven <arjan@linux.intel.com> - 2016-03-10 22:00 +0100
      Re: [PATCH] x86: Enable full randomization on i386 and X86_32. Kees Cook <keescook@chromium.org> - 2016-03-10 22:10 +0100
        Re: [PATCH] x86: Enable full randomization on i386 and X86_32. Ingo Molnar <mingo@kernel.org> - 2016-03-11 10:00 +0100
          Re: [PATCH] x86: Enable full randomization on i386 and X86_32. Kees Cook <keescook@chromium.org> - 2016-03-11 17:20 +0100
  Re: [PATCH] x86: Enable full randomization on i386 and X86_32. Ingo Molnar <mingo@kernel.org> - 2016-03-11 10:00 +0100
  [tip:x86/mm] x86/mm/32: Enable full randomization on i386 and  X86_32 tip-bot for Hector Marco-Gisbert <tipbot@zytor.com> - 2016-03-12 16:20 +0100

csiph-web