Re: [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt

From	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt
Date	2016-03-11 14:30 +0100
Message-ID	<rbviH-6Sm-25@gated-at.bofh.it> (permalink)
References	<r8Mg2-6XZ-1@gated-at.bofh.it> <r8Mg2-6XZ-5@gated-at.bofh.it> <r8Y7w-7tk-9@gated-at.bofh.it> <rbkwW-7et-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello.

On 3/11/2016 4:53 AM, Daode Huang wrote:

>>> In V2 chip, when sending mamagement packets, the driver should
>>> config the port id to BD descs.
>>>
>>> Signed-off-by: Daode Huang <huangdaode@hisilicon.com>
>>> Signed-off-by: Lisheng <lisheng011@huawei.com>
>>> ---
>>>   drivers/net/ethernet/hisilicon/hns/hnae.h         | 3 +++
>>>   drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 1 +
>>>   drivers/net/ethernet/hisilicon/hns/hns_enet.c     | 4 ++++
>>>   3 files changed, 8 insertions(+)
>>>
>>> diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.h
>>> b/drivers/net/ethernet/hisilicon/hns/hnae.h
>>> index 1cbcb9f..11a3f97 100644
>>> --- a/drivers/net/ethernet/hisilicon/hns/hnae.h
>>> +++ b/drivers/net/ethernet/hisilicon/hns/hnae.h
>> [...]
>>> @@ -516,6 +518,7 @@ struct hnae_handle {
>>>       int q_num;
>>>       int vf_id;
>>>       u32 eport_id;
>>> +    u32 dport_id;    /*v2 tx bd should fill the dport_id*/
>>
>>    Please add spaces after /* and before */ (like it's done in other places
>> in this driver).
>>
>
> Hi MBR, Sergei,

    Just in case: MBR stands for "my best regards", Sergei is my name. :-)

> Daode.

MBR, Sergei

Thread

Re: [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-04 14:40 +0100
  Re: [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt Daode Huang <huangdaode@hisilicon.com> - 2016-03-11 03:00 +0100
    Re: [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-11 14:30 +0100
      Re: [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt Daode Huang <huangdaode@hisilicon.com> - 2016-03-14 01:50 +0100

csiph-web