Re: [RFC PATCH v0] Add tw5864 driver

From	Andrey Utkin <andrey.utkin@corp.bluecherry.net>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v0] Add tw5864 driver
Date	2016-03-11 14:30 +0100
Message-ID	<rbviG-6Sm-1@gated-at.bofh.it> (permalink)
References	(3 earlier) <qZQLV-3tN-35@gated-at.bofh.it> <raNrk-Hp-5@gated-at.bofh.it> <rbqj0-3fw-7@gated-at.bofh.it> <rbqVI-3vt-11@gated-at.bofh.it> <rbs1t-4bm-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 11 Mar 2016 10:59:02 +0100
Hans Verkuil <hverkuil@xs4all.nl> wrote:
> While userspace may specify FIELD_ANY when setting a format, the
> driver should always map that to a specific field setting and should
> never return FIELD_ANY back to userspace.
> 
> In this case, the 'field' field of the v4l2_buffer struct has
> FIELD_ANY which means it is not set correctly (or at all) in the
> driver.
> 
> It's a common mistake, which is why v4l2-compliance tests for it :-)

Thanks for great guidance Hans, finally I have solved all issues.

You can review latest state at tw5864 branch, also you can review
changelog of v4l2-compliance fixing at tags tw5864_pre_1.11,
tw5864_pre_1.10 of https://github.com/bluecherrydvr/linux .

I will make a final internal review before submission, and try
to submit the driver for inclusion.

Everybody is appreciated to make any comments even before submission,
the actual code to review is at tw5864 branch.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH v0] Add tw5864 driver Andrey Utkin <andrey.utkin@corp.bluecherry.net> - 2016-03-09 15:40 +0100
  Re: [RFC PATCH v0] Add tw5864 driver Hans Verkuil <hverkuil@xs4all.nl> - 2016-03-11 09:10 +0100
    Re: [RFC PATCH v0] Add tw5864 driver Andrey Utkin <andrey.utkin@corp.bluecherry.net> - 2016-03-11 09:50 +0100
      Re: [RFC PATCH v0] Add tw5864 driver Hans Verkuil <hverkuil@xs4all.nl> - 2016-03-11 11:00 +0100
        Re: [RFC PATCH v0] Add tw5864 driver Andrey Utkin <andrey.utkin@corp.bluecherry.net> - 2016-03-11 14:30 +0100

csiph-web