Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1355851
| From | Hannes Reinecke <hare@suse.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [patch v2] scsi_dh_alua: uninitialized variable in alua_check_vpd() |
| Date | 2016-03-11 12:50 +0100 |
| Message-ID | <rbtJT-5CI-1@gated-at.bofh.it> (permalink) |
| References | <rbtgS-5hR-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 03/11/2016 12:19 PM, Dan Carpenter wrote:
> The pg_updated variable is support to be set to false at the start but
> it is uninitialized.
>
> Fixes: cb0a168cb6b8 ('scsi_dh_alua: update 'access_state' field')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
> index 5bcdf8d..a404a41 100644
> --- a/drivers/scsi/device_handler/scsi_dh_alua.c
> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
> @@ -332,7 +332,7 @@ static int alua_check_vpd(struct scsi_device *sdev, struct alua_dh_data *h,
> {
> int rel_port = -1, group_id;
> struct alua_port_group *pg, *old_pg = NULL;
> - bool pg_updated;
> + bool pg_updated = false;
> unsigned long flags;
>
> group_id = scsi_vpd_tpg_id(sdev, &rel_port);
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[patch] scsi_dh_alua: uninitialized variable in alua_check_vpd() Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-11 11:20 +0100
Re: [patch] scsi_dh_alua: uninitialized variable in alua_check_vpd() Hannes Reinecke <hare@suse.de> - 2016-03-11 12:00 +0100
[patch v2] scsi_dh_alua: uninitialized variable in alua_check_vpd() Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-11 12:20 +0100
Re: [patch v2] scsi_dh_alua: uninitialized variable in alua_check_vpd() Hannes Reinecke <hare@suse.de> - 2016-03-11 12:50 +0100
Re: [patch v2] scsi_dh_alua: uninitialized variable in alua_check_vpd() Manoj Kumar <manoj@linux.vnet.ibm.com> - 2016-03-11 15:50 +0100
Re: [patch v2] scsi_dh_alua: uninitialized variable in alua_check_vpd() "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-03-14 21:10 +0100
Re: [patch] scsi_dh_alua: uninitialized variable in alua_check_vpd() Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-11 12:30 +0100
csiph-web