Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1355821

Re: [PATCH] net: mvneta: Add missing hotplug notifier transition

Show all headers | View raw

Gregory,

On Fri, 11 Mar 2016, Gregory CLEMENT wrote:
>  On ven., mars 11 2016, Anna-Maria Gleixner <anna-maria@linutronix.de> wrote:
> 
> > The mvneta_percpu_notifier() hotplug callback lacks handling of the
> > CPU_DOWN_FAILED case. That means, if CPU_DOWN_PREPARE failes, the
> > driver is not well configured on the CPU.
> >
> > Add handling for CPU_DOWN_FAILED[_FROZEN] hotplug notifier transition
> > to setup the driver.
> 
> I agree that we need to handle this case, however reusing CPU_ONLINE
> case for it seems too much.

Why is that too much? If it does the job, then it's definitely preferrable
over an extra case for a non hotpath error handling operation.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: mvneta: Add missing hotplug notifier transition Anna-Maria Gleixner <anna-maria@linutronix.de> - 2016-03-11 10:20 +0100
  Re: [PATCH] net: mvneta: Add missing hotplug notifier transition Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-03-11 11:30 +0100
    Re: [PATCH] net: mvneta: Add missing hotplug notifier transition Thomas Gleixner <tglx@linutronix.de> - 2016-03-11 12:00 +0100
  Re: [PATCH] net: mvneta: Add missing hotplug notifier transition David Miller <davem@davemloft.net> - 2016-03-14 20:30 +0100

csiph-web