Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1355808

Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines.

From Mika Westerberg <mika.westerberg@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines.
Date 2016-03-11 12:00 +0100
Message-ID <rbsXw-4QJ-13@gated-at.bofh.it> (permalink)
References <raFDs-3W3-21@gated-at.bofh.it> <raMbU-8oX-19@gated-at.bofh.it> <raUj9-5AY-19@gated-at.bofh.it> <rbfQC-3PQ-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 10, 2016 at 09:57:09PM +0100, Rafael J. Wysocki wrote:
> > It doesn't seem to do any runtime PM,
> > I do wonder if pcieport should be doing it's own runtime PM handling,
> > but that is a
> > larger task than I'm thinking to tackle here.
> 
> PCIe ports don't do PM - yet.  Mika has posted a series of patches to implement
> that, however, that are waiting for comments now:
> 
> https://patchwork.kernel.org/patch/8453311/
> https://patchwork.kernel.org/patch/8453381/
> https://patchwork.kernel.org/patch/8453391/
> https://patchwork.kernel.org/patch/8453411/
> https://patchwork.kernel.org/patch/8453371/
> https://patchwork.kernel.org/patch/8453351/
> 
> > Maybe I should be doing
> > 
> > pci_set_power_state(pdev->bus->self, PCI_D3cold) ? I'm not really sure.
> 
> Using pci_set_power_state() would be more appropriate IMO, but you can get
> to the bridge via dev->parent too, can't you?
> 
> In any case, it looks like you and Mika need to talk. :-)

When the vga_switcheroo device gets runtime suspended (with the above
runtime PM patchs for PCIe root ports) the root port should also be
runtime suspended by the PM core. I don't think there is a need to call
any pci_set_power_state() in this driver but maybe I'm missing
something.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] vga_switcheroo: add power support for windows 10 machines. Dave Airlie <airlied@gmail.com> - 2016-03-09 07:20 +0100
  Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines. "Rafael J. Wysocki" <rafael@kernel.org> - 2016-03-09 14:20 +0100
    Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines. Dave Airlie <airlied@gmail.com> - 2016-03-09 23:00 +0100
      Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines. "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-03-10 22:00 +0100
        Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10  machines. Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-03-11 12:00 +0100
          Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines. "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-03-11 14:50 +0100
            Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines. Dave Airlie <airlied@gmail.com> - 2016-03-14 03:20 +0100
              Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines. Dave Airlie <airlied@gmail.com> - 2016-03-14 10:50 +0100
                Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10  machines. Daniel Vetter <daniel@ffwll.ch> - 2016-03-14 11:10 +0100
                Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10  machines. Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-03-14 11:30 +0100
                Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines. "Rafael J. Wysocki" <rafael@kernel.org> - 2016-03-14 14:00 +0100
                Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10  machines. Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-03-14 15:40 +0100
              Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10  machines. Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-03-14 10:50 +0100
                Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10  machines. Lukas Wunner <lukas@wunner.de> - 2016-03-15 14:40 +0100
                Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10  machines. Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-03-15 15:00 +0100
              Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines. Alex Deucher <alexdeucher@gmail.com> - 2016-03-14 15:40 +0100
  Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10  machines. Lukas Wunner <lukas@wunner.de> - 2016-03-09 15:40 +0100
    Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines. Alex Deucher <alexdeucher@gmail.com> - 2016-03-09 18:00 +0100
      Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10  machines. Lukas Wunner <lukas@wunner.de> - 2016-03-09 21:20 +0100
        Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines. Alex Deucher <alexdeucher@gmail.com> - 2016-03-09 21:30 +0100
        Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines. Dave Airlie <airlied@gmail.com> - 2016-03-09 23:10 +0100
    Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines. Dave Airlie <airlied@gmail.com> - 2016-03-09 23:10 +0100

csiph-web